Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 862163002: Use signed long for FPDF_GetNamedDest buffer length. (Closed)

Created:
5 years, 11 months ago by Bo Xu
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use signed long for FPDF_GetNamedDest buffer length. Need to have return value -1 indicating insufficient buffer. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/dc43b322915c5256a5a9458e6b8cd28bcecf91ae

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M fpdfsdk/include/fpdfview.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bo Xu
Hi Tom, please review this.
5 years, 11 months ago (2015-01-21 21:43:51 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/862163002/diff/1/fpdfsdk/include/fpdfview.h File fpdfsdk/include/fpdfview.h (right): https://codereview.chromium.org/862163002/diff/1/fpdfsdk/include/fpdfview.h#newcode629 fpdfsdk/include/fpdfview.h:629: // buflen - The length of the buffer ...
5 years, 11 months ago (2015-01-21 21:51:29 UTC) #3
Bo Xu
https://codereview.chromium.org/862163002/diff/1/fpdfsdk/include/fpdfview.h File fpdfsdk/include/fpdfview.h (right): https://codereview.chromium.org/862163002/diff/1/fpdfsdk/include/fpdfview.h#newcode631 fpdfsdk/include/fpdfview.h:631: // The destination handle of a named destination, NULL ...
5 years, 11 months ago (2015-01-21 22:00:26 UTC) #4
Tom Sepez
> Currently we still return destination when querying. If you want, I can change > ...
5 years, 11 months ago (2015-01-21 22:10:06 UTC) #5
Bo Xu
5 years, 11 months ago (2015-01-21 22:20:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc43b322915c5256a5a9458e6b8cd28bcecf91ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698