build/android/pylib/utils/findbugs.py - Issue 862133002: Update from https://crrev.com/312398

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/findbugs.py

Issue 862133002: Update from https://crrev.com/312398 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/utils/findbugs.py

diff --git a/build/android/pylib/utils/findbugs.py b/build/android/pylib/utils/findbugs.py

index d946f319f14043899ab8caac67e46fbef7f2de5d..82408b017d85b219f1e8e5036b57c7dfb2901279 100644

--- a/build/android/pylib/utils/findbugs.py

+++ b/build/android/pylib/utils/findbugs.py

@@ -32,8 +32,11 @@ def _StripLineNumbers(current_warnings):

def _DiffKnownWarnings(current_warnings_set, known_bugs_file):

- with open(known_bugs_file, 'r') as known_bugs:

- known_bugs_set = set(known_bugs.read().splitlines())

+ if os.path.exists(known_bugs_file):

+ with open(known_bugs_file, 'r') as known_bugs:

+ known_bugs_set = set(known_bugs.read().splitlines())

+ else:

+ known_bugs_set = set()

new_warnings = current_warnings_set - known_bugs_set

_PrintMessage(sorted(new_warnings), 'New', 'Please fix, or perhaps add to',