Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Unified Diff: build/android/findbugs_filter/findbugs_exclude.xml

Issue 862133002: Update from https://crrev.com/312398 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/findbugs_filter/findbugs_exclude.xml
diff --git a/build/android/findbugs_filter/findbugs_exclude.xml b/build/android/findbugs_filter/findbugs_exclude.xml
index 0fff63624333059a8e4a2acbcf777070f4877ba4..fba286df30d91e30c0e1a1d7b66277af367d8c07 100644
--- a/build/android/findbugs_filter/findbugs_exclude.xml
+++ b/build/android/findbugs_filter/findbugs_exclude.xml
@@ -17,29 +17,8 @@ In particular, ~ at the start of a string means it's a regex.
<Match>
<Class name="~org\.chromium\..*\.Manifest(\$\w+)?" />
</Match>
- <!-- Ignore bugs in NativeLibraries.java (the auto-generation confuses findbugs). -->
- <Match>
- <Class name="~org\.chromium\.base\..*\.NativeLibraries.*?" />
- </Match>
- <!--
- Ignore bugs in CleanupReferenceTest.java (redundant null check)
- TODO(joth): Group all GC related tests and filter them out, since the null
- check is necessary to make sure the nullification is flushed to memory.
- -->
- <Match>
- <Class name="~org\.chromium\.content\..*\.CleanupReferenceTest.*?" />
- </Match>
- <!-- Ignore errors in JavaBridge due to reflection. -->
- <Match>
- <Class name="~.*\.JavaBridge.*"/>
- <Bug code="UuF,UrF,UMAC" />
- </Match>
- <!-- "Struct" like classes expect to have unused public data members -->
- <Match>
- <Class name="~.*android_webview.*FileChooserParams"/>
- <Bug code="UrF" />
- </Match>
<!-- Ignore "reliance on default String encoding" warnings, as we're not multi-platform -->
+
<Bug pattern="DM_DEFAULT_ENCODING" />
<!-- Ignore bugs that are often false-positives in test code -->
<Match>
@@ -50,67 +29,14 @@ In particular, ~ at the start of a string means it's a regex.
</Or>
</Match>
<!--
- Ignore calls to System.exit() following errors during loading the native library.
- There is no way to recover from such errors without restarting the application,
- so System.exit() is the best solution.
+ crbug.com/449101
+ Ignore findbugs plugin test cases.
-->
<Match>
- <Class name="~org\.chromium\.chrome\..*\.ChromiumSyncAdapter.*" />
- <Method name="run" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\.chrome\..*\.ChromiumSyncAdapter" />
- <Method name="startBrowserProcessesSync" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\.chrome\..*\.ChromeShellActivity" />
- <Method name="onCreate" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\.chrome\..*\.AccountsChangedReceiver.*" />
- <Method name="run" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\.chrome\..*\.NotificationService" />
- <Method name="dispatchIntentOnUIThread" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="org.chromium.chrome.browser.preferences.Preferences" />
- <Method name="onCreate" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\.content\..*\.ChildProcessService.*" />
- <Method name="run" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\..*ContentBrowserTestsActivity" />
- <Method name="onCreate" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\..*ContentShellActivity" />
- <Method name="onCreate" />
- <Bug code="Dm" />
- </Match>
- <Match>
- <Class name="~org\.chromium\.components\.gcm_driver\..*\.GCMDriver" />
- <Method name="launchNativeThen" />
- <Bug code="Dm" />
- </Match>
- <!--
- Ignore write to static field in GCMDriver, as it's the cleanest way to mark
- the singleton as null when the native counterpart is destroyed.
- -->
- <Match>
- <Class name="~org\.chromium\.components\.gcm_driver\..*\.GCMDriver" />
- <Method name="destroy" />
- <Bug code="ST" />
+ <Or>
+ <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedMethod" />
+ <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedStaticMethod" />
+ <Class name="~org\.chromium\.tools\.findbugs\.plugin\.SimpleSynchronizedThis" />
+ </Or>
</Match>
</FindBugsFilter>

Powered by Google App Engine
This is Rietveld 408576698