Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: net/quic/quic_connection.h

Issue 862133002: Update from https://crrev.com/312398 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_connection.h
diff --git a/net/quic/quic_connection.h b/net/quic/quic_connection.h
index 0ffc3e851bfc45cc995b9acbf6c3a08ddd36afb6..8afd79d6a5ffa333c43666d63f75ae36dd4c4704 100644
--- a/net/quic/quic_connection.h
+++ b/net/quic/quic_connection.h
@@ -162,10 +162,6 @@ class NET_EXPORT_PRIVATE QuicConnectionDebugVisitor
// Called when a AckFrame has been parsed.
virtual void OnAckFrame(const QuicAckFrame& frame) {}
- // Called when a CongestionFeedbackFrame has been parsed.
- virtual void OnCongestionFeedbackFrame(
- const QuicCongestionFeedbackFrame& frame) {}
-
// Called when a StopWaitingFrame has been parsed.
virtual void OnStopWaitingFrame(const QuicStopWaitingFrame& frame) {}
@@ -360,8 +356,6 @@ class NET_EXPORT_PRIVATE QuicConnection
void OnFecProtectedPayload(base::StringPiece payload) override;
bool OnStreamFrame(const QuicStreamFrame& frame) override;
bool OnAckFrame(const QuicAckFrame& frame) override;
- bool OnCongestionFeedbackFrame(
- const QuicCongestionFeedbackFrame& frame) override;
bool OnStopWaitingFrame(const QuicStopWaitingFrame& frame) override;
bool OnPingFrame(const QuicPingFrame& frame) override;
bool OnRstStreamFrame(const QuicRstStreamFrame& frame) override;
@@ -377,7 +371,6 @@ class NET_EXPORT_PRIVATE QuicConnection
HasRetransmittableData retransmittable,
IsHandshake handshake) override;
QuicAckFrame* CreateAckFrame() override;
- QuicCongestionFeedbackFrame* CreateFeedbackFrame() override;
QuicStopWaitingFrame* CreateStopWaitingFrame() override;
void OnSerializedPacket(const SerializedPacket& packet) override;
@@ -451,6 +444,10 @@ class NET_EXPORT_PRIVATE QuicConnection
// remaining unacked packets.
void OnRetransmissionTimeout();
+ // Called when a data packet is sent. Starts an alarm if the data sent in
+ // |sequence_number| was FEC protected.
+ void MaybeSetFecAlarm(QuicPacketSequenceNumber sequence_number);
+
// Retransmits all unacked packets with retransmittable frames if
// |retransmission_type| is ALL_UNACKED_PACKETS, otherwise retransmits only
// initially encrypted packets. Used when the negotiated protocol version is
@@ -707,7 +704,6 @@ class NET_EXPORT_PRIVATE QuicConnection
QuicPacketHeader last_header_;
std::vector<QuicStreamFrame> last_stream_frames_;
std::vector<QuicAckFrame> last_ack_frames_;
- std::vector<QuicCongestionFeedbackFrame> last_congestion_frames_;
std::vector<QuicStopWaitingFrame> last_stop_waiting_frames_;
std::vector<QuicRstStreamFrame> last_rst_frames_;
std::vector<QuicGoAwayFrame> last_goaway_frames_;
@@ -716,8 +712,6 @@ class NET_EXPORT_PRIVATE QuicConnection
std::vector<QuicPingFrame> last_ping_frames_;
std::vector<QuicConnectionCloseFrame> last_close_frames_;
- QuicCongestionFeedbackFrame outgoing_congestion_feedback_;
-
// Track some peer state so we can do less bookkeeping
// Largest sequence sent by the peer which had an ack frame (latest ack info).
QuicPacketSequenceNumber largest_seen_packet_with_ack_;
@@ -781,6 +775,9 @@ class NET_EXPORT_PRIVATE QuicConnection
scoped_ptr<QuicConnectionDebugVisitor> debug_visitor_;
QuicPacketGenerator packet_generator_;
+ // An alarm that fires when an FEC packet should be sent.
+ scoped_ptr<QuicAlarm> fec_alarm_;
+
// Network idle time before we kill of this connection.
QuicTime::Delta idle_network_timeout_;
// Overall connection timeout.
« no previous file with comments | « net/quic/quic_config_test.cc ('k') | net/quic/quic_connection.cc » ('j') | shell/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698