Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: net/proxy/proxy_info.h

Issue 862133002: Update from https://crrev.com/312398 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_info.h
diff --git a/net/proxy/proxy_info.h b/net/proxy/proxy_info.h
index e1c938946749dee2a3419685e3687e9f6a9d634c..8e78d9f916fc42661d7a9f62924c04205496d8cf 100644
--- a/net/proxy/proxy_info.h
+++ b/net/proxy/proxy_info.h
@@ -29,25 +29,40 @@ class NET_EXPORT ProxyInfo {
void Use(const ProxyInfo& proxy_info);
// Uses a direct connection.
+ //
+ // Note that this method resets this instance unlike Fallback(), etc. which
+ // only modify |proxy_list_|. For example, since |config_id_| is cleared, the
+ // ProxyService may recognize this instance as a new config after UseDirect()
+ // call.
void UseDirect();
// Uses a direct connection. did_bypass_proxy() will return true to indicate
// that the direct connection is the result of configured proxy bypass rules.
+ //
+ // See also the note for UseDirect().
void UseDirectWithBypassedProxy();
// Uses a specific proxy server, of the form:
// proxy-uri = [<scheme> "://"] <hostname> [":" <port>]
// This may optionally be a semi-colon delimited list of <proxy-uri>.
// It is OK to have LWS between entries.
+ //
+ // See also the note for UseDirect().
void UseNamedProxy(const std::string& proxy_uri_list);
// Sets the proxy list to a single entry, |proxy_server|.
+ //
+ // See also the note for UseDirect().
void UseProxyServer(const ProxyServer& proxy_server);
// Parses from the given PAC result.
+ //
+ // See also the note for UseDirect().
void UsePacString(const std::string& pac_string);
// Uses the proxies from the given list.
+ //
+ // See also the note for UseDirect().
void UseProxyList(const ProxyList& proxy_list);
// Uses the proxies from the given list, but does not otherwise reset the
« no previous file with comments | « net/proxy/proxy_config_source.cc ('k') | net/proxy/proxy_service.cc » ('j') | shell/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698