Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 862113005: Create a Android Sync integration test for typed URLs (Closed)

Created:
5 years, 11 months ago by pval...(no longer on Chromium)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a Android Sync integration test for typed URLs This CL introduces JNI plumbing for one method of the FakeServer's verification API. One test (testUploadTypedUrl) has been added to use the API; it types a URL on the client and verifies that the URL was sent to the server. BUG=NONE Committed: https://crrev.com/cba424b9309c8c75d0a3797b9b228f7ef11425e4 Cr-Commit-Position: refs/heads/master@{#313824}

Patch Set 1 : #

Total comments: 10

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : create FakeServerHelper on UI thread #

Patch Set 5 : fixes added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -1 line) Patch
M chrome/android/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java View 1 3 chunks +23 lines, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java View 1 2 3 4 chunks +38 lines, -0 lines 0 comments Download
M sync/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sync/sync_tests.gypi View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.cc View 1 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
pval...(no longer on Chromium)
5 years, 11 months ago (2015-01-22 02:15:57 UTC) #5
pval...(no longer on Chromium)
ping
5 years, 11 months ago (2015-01-23 19:12:52 UTC) #6
nyquist
lgtm. amazing! if there really is no bug for upstreaming sync tests, could you please ...
5 years, 11 months ago (2015-01-24 01:54:41 UTC) #7
maxbogue
lgtm with Tommy's comments! https://codereview.chromium.org/862113005/diff/60001/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java File chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java (right): https://codereview.chromium.org/862113005/diff/60001/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java#newcode117 chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java:117: * Returns whether {@count code} ...
5 years, 11 months ago (2015-01-24 20:47:03 UTC) #8
pval...(no longer on Chromium)
+zea for sync/ OWNERS https://codereview.chromium.org/862113005/diff/60001/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java File chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java (right): https://codereview.chromium.org/862113005/diff/60001/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java#newcode117 chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java:117: * Returns whether {@count code} ...
5 years, 11 months ago (2015-01-27 22:14:48 UTC) #11
Nicolas Zea
Awesome, LGTM!
5 years, 10 months ago (2015-01-29 00:28:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862113005/100001
5 years, 10 months ago (2015-01-29 00:34:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/5300)
5 years, 10 months ago (2015-01-29 00:36:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862113005/120001
5 years, 10 months ago (2015-01-29 01:20:34 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/49772)
5 years, 10 months ago (2015-01-29 02:26:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862113005/140001
5 years, 10 months ago (2015-01-29 21:48:07 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:140001)
5 years, 10 months ago (2015-01-29 23:29:15 UTC) #23
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/cba424b9309c8c75d0a3797b9b228f7ef11425e4 Cr-Commit-Position: refs/heads/master@{#313824}
5 years, 10 months ago (2015-01-29 23:30:20 UTC) #24
Miguel Garcia
5 years, 10 months ago (2015-01-30 11:19:29 UTC) #25
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:140001) has been created in
https://codereview.chromium.org/881753003/ by miguelg@chromium.org.

The reason for reverting is: This is breaking building
chrome/android:chrome_sync_shell_test_apk
with gn due to a dependency to the autogenerated enum
org.chromium.ui.base.PageTransition;


I am not sure why no bots failed when landing it (we don't seem to have gn
builder upstream for android?) but reverting it locally makes it build again.


To repro: Reapply the patch and run
gn gen out/Release  --args='is_debug=false os="android" cpu_arch="arm"
use_goma=true goma_dir="/usr/local/google/clank/goma/goma"'

ninja -C out/Release -j 200  chrome/android:chrome_sync_shell_test_apk



.

Powered by Google App Engine
This is Rietveld 408576698