Simplify SkPDFShader class. Now invalid objects are never created.

src/pdf/SkPDFShader.h

Index: src/pdf/SkPDFShader.h
diff --git a/src/pdf/SkPDFShader.h b/src/pdf/SkPDFShader.h
index e0abff8f68388324128cbe15bfebfc4d49540bc2..a9bfe7ac35949ee3e763495834763b5e7d76d0b8 100644
--- a/src/pdf/SkPDFShader.h
+++ b/src/pdf/SkPDFShader.h
@@ -50,19 +50,15 @@ public:
 
 protected:
     SkAutoTDelete<const State> fShaderState;
+    SkPDFObject* fSelf;

[mtklein, 2015/01/22 15:54:30]

This is just aching for a comment.  My first thought is, WTF, you mean 'this'?

 
     // This is an internal method.
     // CanonicalShadersMutex() should already be acquired.
     // This also takes ownership of shaderState.
     static SkPDFObject* GetPDFShaderByState(State* shaderState);
-    static SkPDFObject* AddToCanonIfValid(SkPDFShader*);
-    static void RemoveFromCanonIfValid(SkPDFShader*);
 
-    SkPDFShader(State*);
-    virtual ~SkPDFShader();
-
-    virtual bool isValid() = 0;
-    virtual SkPDFObject* toPDFObject() = 0;
+    SkPDFShader(State* s);
+    ~SkPDFShader();
 };
 
 #endif