Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3146)

Unified Diff: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

Issue 862103002: Only store leading 13 bits of password hash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make LocalAuth a class so methods can be private and exposed only to tests. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
diff --git a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
index 91a5bce179edad88405345fd32f252e11d843bb6..b13580032aa78c83fe2dd44aa30c04761e41964a 100644
--- a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
+++ b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
@@ -341,7 +341,7 @@ void UserManagerScreenHandler::HandleAuthenticatedLaunchUser(
}
authenticating_profile_index_ = profile_index;
- if (!chrome::ValidateLocalAuthCredentials(profile_index, password)) {
+ if (!LocalAuth::ValidateLocalAuthCredentials(profile_index, password)) {
// Make a second attempt via an on-line authentication call. This handles
// profiles that are missing sign-in credentials and also cases where the
// password has been changed externally.
@@ -453,8 +453,8 @@ void UserManagerScreenHandler::HandleHardlockUserPod(
void UserManagerScreenHandler::OnClientLoginSuccess(
const ClientLoginResult& result) {
- chrome::SetLocalAuthCredentials(authenticating_profile_index_,
- password_attempt_);
+ LocalAuth::SetLocalAuthCredentials(authenticating_profile_index_,
+ password_attempt_);
ReportAuthenticationResult(true, ProfileMetrics::AUTH_ONLINE);
}
@@ -475,8 +475,8 @@ void UserManagerScreenHandler::OnClientLoginFailure(
// profile was locked. Save the password to streamline future unlocks.
if (success) {
DCHECK(!password_attempt_.empty());
- chrome::SetLocalAuthCredentials(authenticating_profile_index_,
- password_attempt_);
+ LocalAuth::SetLocalAuthCredentials(authenticating_profile_index_,
+ password_attempt_);
}
bool offline = (state == GoogleServiceAuthError::CONNECTION_FAILED ||
« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_handler_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698