chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 862103002: Only store leading 13 bits of password hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 862103002: Only store leading 13 bits of password hash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make LocalAuth a class so methods can be private and exposed only to tests. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index 308460c7b8e85bf147ac5d46d7157e6852a50833..d9ed6882a2324458d01520760ef12797b0cd1eb0 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -140,7 +140,7 @@ void InlineSigninHelper::OnClientOAuthSuccess(const ClientOAuthResult& result) {

switches::IsNewProfileManagement() &&

!password_.empty() &&

profiles::IsLockAvailable(profile_)) {

- chrome::SetLocalAuthCredentials(profile_, password_);

+ LocalAuth::SetLocalAuthCredentials(profile_, password_);

}

if (source == signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT ||