Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 862063002: Reland Queue commands to the Os to start a video device. (Closed)

Created:
5 years, 11 months ago by perkj_chrome
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Queue commands to the Os to start a video device. This cl reland Queue commands to the Os to start a video device, originally reviewed in https://codereview.chromium.org/801363002. (patchset 1) In patchset 2, the issue found in crbug/450382 related to patchset(1) is addressed. |Device| is made into a class and thread checks are added. BUG=428891, 450382, 450226 Committed: https://crrev.com/58af7960deb5d850cde69b90f119dd00d298a191 Cr-Commit-Position: refs/heads/master@{#313708}

Patch Set 1 #

Patch Set 2 : Fixed problem with SetDesktopCaptureWindowIdOnDeviceThread #

Patch Set 3 : Add thread dcheck #

Patch Set 4 : Wait for video device thread before ending start/stop test #

Patch Set 5 : Removed valgrind suppression. crbug/450226 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -93 lines) Patch
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 2 3 4 chunks +82 lines, -18 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 2 18 chunks +198 lines, -64 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
perkj_chrome
Can you please take a look?
5 years, 11 months ago (2015-01-21 15:08:48 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 11 months ago (2015-01-23 10:28:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862063002/20001
5 years, 11 months ago (2015-01-23 10:29:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/112984) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96912)
5 years, 11 months ago (2015-01-23 10:29:55 UTC) #7
perkj_chrome
Tommi- can you please take a look at the latest patchset?
5 years, 11 months ago (2015-01-26 17:46:45 UTC) #8
perkj_chrome
On 2015/01/26 17:46:45, perkj wrote: > Tommi- can you please take a look at the ...
5 years, 10 months ago (2015-01-29 07:49:47 UTC) #9
tommi (sloooow) - chröme
lgtm
5 years, 10 months ago (2015-01-29 14:19:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862063002/80001
5 years, 10 months ago (2015-01-29 14:38:40 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-01-29 15:24:43 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 15:26:32 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/58af7960deb5d850cde69b90f119dd00d298a191
Cr-Commit-Position: refs/heads/master@{#313708}

Powered by Google App Engine
This is Rietveld 408576698