Issue 861983002: Attempt to fix the ASAN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 861983002: Attempt to fix the ASAN build (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, zra_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Attempt to fix the ASAN build The gn build system in Dart can't quite build with ASAN. We'll need to fix that in the Dart repo in order to re-enable building dart_content_handler with ASAN. TBR=jamesr@chromium.og Committed: https://chromium.googlesource.com/external/mojo/+/f67958830d6b6787b31d67d99ccc674c28a00a5a

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	mojo/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	services/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 11 months ago (2015-01-21 04:40:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f67958830d6b6787b31d67d99ccc674c28a00a5a (presubmit successful).

Expand Messages | Collapse Messages