Initial CL to create SDK directory (this will be done as a build step).

Initial CL to create SDK directory (this will be done via the usual gyp and tools/build.py process).

Proposed top-level structure:
..sdk/
....bin/
......dart or dart.exe (executable)
......frogc.dart
......frogsh (coming later)
....lib/
......core/
........core_{compiler, frog, runtime}.dart
........{compiler, frog, runtime}/ 
......coreimpl/
........coreimpl_{compiler, frog, runtime}.dart
........{compiler, frog, runtime}/ 
......dom/
........dom.dart
......frog/
......html/ 
........html.dart
......htmlimpl/ 
........htmlimpl.dart
......(more will come here - io, etc)
....tools/
......dartdoc/
......(more will come here)
Committed: https://code.google.com/p/dart/source/detail?r=2040

[dgrove, 2011-11-21 23:25:42]

This is a first shot at creating an SDK for Dart. The idea here is that this
would be used for:

* Dart command-line developers who want to either run on the server VM or who
want to create JS.
* The editor, which would package this SDK.

Jim, in particular, note that there's some messing around that has to be done to
massage frog into a state where it works in this SDK. I'm very open to
suggestions on making this better. FrogOptions.config is needed because we lack
a packaging system.

[Siggi Cherem (dart-lang), 2011-11-21 23:44:23]

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart
File frog/frog_options.dart (right):

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart#newco...
frog/frog_options.dart:25: /* TODO(dgrove): fix this. For now, either 'sdk' or
'dev'. */
nit: use // comments for TODOs rather than /* (so they don't get pulled into
dartdocs)

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart#newco...
frog/frog_options.dart:55: libDir = homedir + '/../lib/corelib/frog';
it might be good to call [joinPaths] and [dirname] here and above (definitions
in file_system.dart)

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart#newco...
frog/frog_options.dart:147: if (!passedLibDir && !files.fileExists(libDir +
"/corelib.dart")) {
why is this change needed?

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode1
tools/create_sdk.py:1: #!/usr/bin/env python
+ copyright
+ top-level comments """
"""

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode23
tools/create_sdk.py:23: # copy the Dart VM binary into sdk/bin
Capitalize comments and end with .  (here and below)

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode24
tools/create_sdk.py:24: build_dir = utils.GetBuildRoot(utils.GuessOS(),
'release', 'ia32') #TODO(dgrove)
explain TODO, move it to its own line

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode85
tools/create_sdk.py:85: copytree(join(html_src_dir, 'src'), join(html_dest_dir,
'src'))
Alternatively, we should copy html.dart from the release directory
(html/client/release), which is also what frog uses in 'dev' mode.

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode91
tools/create_sdk.py:91: if filename.endswith('.dart') or
filename.endswith('.js'):
should we skip the monkey patching and wrapper versions?

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode107
tools/create_sdk.py:107: dest_file.write(re.sub("../../corelib/src/",
"../share/", contents))
I'm not convinced about having the 'share' dir, why not put them directly under
corelib/ ?

If we need a shared directory, I'd prefer 'shared' or 'common' rather than
'share'.

[dgrove, 2011-11-22 00:41:24]

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart
File frog/frog_options.dart (right):

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart#newco...
frog/frog_options.dart:25: /* TODO(dgrove): fix this. For now, either 'sdk' or
'dev'. */
On 2011/11/21 23:44:23, sigmund wrote:
> nit: use // comments for TODOs rather than /* (so they don't get pulled into
> dartdocs)

Done.

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart#newco...
frog/frog_options.dart:55: libDir = homedir + '/../lib/corelib/frog';
On 2011/11/21 23:44:23, sigmund wrote:
> it might be good to call [joinPaths] and [dirname] here and above (definitions
> in file_system.dart)

Done.

http://codereview.chromium.org/8619005/diff/1004/frog/frog_options.dart#newco...
frog/frog_options.dart:147: if (!passedLibDir && !files.fileExists(libDir +
"/corelib.dart")) {
On 2011/11/21 23:44:23, sigmund wrote:
> why is this change needed? 

A good question - because files.fileExists doesn't work for a directory. If you
run this line here:

    print("file exists: ${files.fileExists(libDir + '/corelib.dart')}
${files.fileExists(libDir)}");

you'll get "file exists: true false" as the output (at least when running on the
VM).

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode1
tools/create_sdk.py:1: #!/usr/bin/env python
On 2011/11/21 23:44:23, sigmund wrote:
> + copyright
> + top-level comments """
> """

Done.

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode23
tools/create_sdk.py:23: # copy the Dart VM binary into sdk/bin
On 2011/11/21 23:44:23, sigmund wrote:
> Capitalize comments and end with .  (here and below)

Done.

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode24
tools/create_sdk.py:24: build_dir = utils.GetBuildRoot(utils.GuessOS(),
'release', 'ia32') #TODO(dgrove)
On 2011/11/21 23:44:23, sigmund wrote:
> explain TODO, move it to its own line

Done.

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode85
tools/create_sdk.py:85: copytree(join(html_src_dir, 'src'), join(html_dest_dir,
'src'))
On 2011/11/21 23:44:23, sigmund wrote:
> Alternatively, we should copy html.dart from the release directory
> (html/client/release), which is also what frog uses in 'dev' mode.

Done.

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode91
tools/create_sdk.py:91: if filename.endswith('.dart') or
filename.endswith('.js'):
On 2011/11/21 23:44:23, sigmund wrote:
> should we skip the monkey patching and wrapper versions?

Done.

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode107
tools/create_sdk.py:107: dest_file.write(re.sub("../../corelib/src/",
"../share/", contents))
I'd like to head in the direction of having a common structure for each of the
libs, where some kind of common sits in parallel with other specific
implementations. Code review is probably not the best place to explain this, so
I'll do it offline.
On 2011/11/21 23:44:23, sigmund wrote:
> I'm not convinced about having the 'share' dir, why not put them directly
under
> corelib/ ?
> 
> If we need a shared directory, I'd prefer 'shared' or 'common' rather than
> 'share'.

[Ivan Posva, 2011-11-22 06:54:42]

We will need to figure out the layout of SDKs that contain binaries for more
than one architecture.

-Ivan

http://codereview.chromium.org/8619005/diff/7001/dart.gyp
File dart.gyp (right):

http://codereview.chromium.org/8619005/diff/7001/dart.gyp#newcode48
dart.gyp:48: 'inputs': [],
You need to have the script file be one of the inputs otherwise it will not
trigger a rerun if you change the script. For an example please take a look at
the generate_corelib_cc action in vm.gypi.

http://codereview.chromium.org/8619005/diff/7001/dart.gyp#newcode54
dart.gyp:54: 'message': 'Creating SDK',
.

http://codereview.chromium.org/8619005/diff/7001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/7001/tools/create_sdk.py#newcode50
tools/create_sdk.py:50: # TODO(dgrove) - deal with architectures that are not
ia32
How do you plan to deal with SDKs for x64 or arm? Somehow this script should be
configured by the currently building configuration.

[Siggi Cherem (dart-lang), 2011-11-22 17:15:20]

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/1004/tools/create_sdk.py#newcode107
tools/create_sdk.py:107: dest_file.write(re.sub("../../corelib/src/",
"../share/", contents))
On 2011/11/22 00:41:24, dgrove wrote:
> I'd like to head in the direction of having a common structure for each of the
> libs, where some kind of common sits in parallel with other specific
> implementations. Code review is probably not the best place to explain this,
so
> I'll do it offline.
> On 2011/11/21 23:44:23, sigmund wrote:
> > I'm not convinced about having the 'share' dir, why not put them directly
> under
> > corelib/ ?
> > 
> > If we need a shared directory, I'd prefer 'shared' or 'common' rather than
> > 'share'.
> 

Here is a proposal, based on what we discussed in person:

lib/
. corelib/
... *.dart  (from dart/corelib/src/*.dart)
... common/ (from dart/corelib/src/implementation/*.dart)
... frog/   (from dart/frog/lib)
. dom/
... *.dart (interfaces)
... frog/
. html/

[dgrove, 2011-11-22 19:18:51]

http://codereview.chromium.org/8619005/diff/7001/dart.gyp
File dart.gyp (right):

http://codereview.chromium.org/8619005/diff/7001/dart.gyp#newcode48
dart.gyp:48: 'inputs': [],
On 2011/11/22 06:54:42, Ivan Posva wrote:
> You need to have the script file be one of the inputs otherwise it will not
> trigger a rerun if you change the script. For an example please take a look at
> the generate_corelib_cc action in vm.gypi.

Done.

http://codereview.chromium.org/8619005/diff/7001/dart.gyp#newcode54
dart.gyp:54: 'message': 'Creating SDK',
On 2011/11/22 06:54:42, Ivan Posva wrote:
> .

Done.

http://codereview.chromium.org/8619005/diff/7001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/7001/tools/create_sdk.py#newcode50
tools/create_sdk.py:50: # TODO(dgrove) - deal with architectures that are not
ia32
On 2011/11/22 06:54:42, Ivan Posva wrote:
> How do you plan to deal with SDKs for x64 or arm? Somehow this script should
be
> configured by the currently building configuration.

I don't have a plan yet,  but I definitely agree that the gyp file should drive
this. I added a main() to this program so that we have a reasonable place to
pass things in.

perhaps we could create sdk-macos-x64, or something like that?

[dgrove, 2011-12-02 22:31:38]

This is a big change over the previous one, based on much discussion with
iposva, sigmund, danrubel .

Siggi - if you could take a look, I'd appreciate it.

[Siggi Cherem (dart-lang), 2011-12-02 22:45:13]

lgtm (w/minor comments below)

http://codereview.chromium.org/8619005/diff/19001/frog/frog_options.dart
File frog/frog_options.dart (right):

http://codereview.chromium.org/8619005/diff/19001/frog/frog_options.dart#newc...
frog/frog_options.dart:60: world.error('Invalid reader configuration $config',
null);
maybe remove 'reader'? (it's not clear to me as a user seeing this error what it
means)

http://codereview.chromium.org/8619005/diff/19001/frog/reader.dart
File frog/reader.dart (right):

http://codereview.chromium.org/8619005/diff/19001/frog/reader.dart#newcode27
frog/reader.dart:27: 'dart:coreimpl': joinPaths(options.libDir,
'coreimpl/coreimpl_frog.dart'),
80 col

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode20
tools/create_sdk.py:20: # ........runtime/
mention also compiler/ ?

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode50
tools/create_sdk.py:50: corelib_sources =
(eval(open("corelib/src/corelib_sources.gypi").read()))['sources']
80 col here and below

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode64
tools/create_sdk.py:64: # Create and populate sdk/bin.
also indent comments

[danrubel, 2011-12-02 23:03:05]

lgtm

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode20
tools/create_sdk.py:20: # ........runtime/
On 2011/12/02 22:45:13, sigmund wrote:
> mention also compiler/ ? 

We are currently bundling DartC libraries as part of Dart Editor.
We can continue to do so if they are not part of this sdk,
although it would be more convenient if they were...

[dgrove, 2011-12-02 23:05:19]

http://codereview.chromium.org/8619005/diff/19001/frog/frog_options.dart
File frog/frog_options.dart (right):

http://codereview.chromium.org/8619005/diff/19001/frog/frog_options.dart#newc...
frog/frog_options.dart:60: world.error('Invalid reader configuration $config',
null);
On 2011/12/02 22:45:13, sigmund wrote:
> maybe remove 'reader'? (it's not clear to me as a user seeing this error what
it
> means)

Done.

http://codereview.chromium.org/8619005/diff/19001/frog/reader.dart
File frog/reader.dart (right):

http://codereview.chromium.org/8619005/diff/19001/frog/reader.dart#newcode27
frog/reader.dart:27: 'dart:coreimpl': joinPaths(options.libDir,
'coreimpl/coreimpl_frog.dart'),
On 2011/12/02 22:45:13, sigmund wrote:
> 80 col

Done.

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode20
tools/create_sdk.py:20: # ........runtime/
On 2011/12/02 22:45:13, sigmund wrote:
> mention also compiler/ ? 

Done.

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode20
tools/create_sdk.py:20: # ........runtime/
I've added compiler for core and coreimpl in this patch.
On 2011/12/02 23:03:06, danrubel wrote:
> On 2011/12/02 22:45:13, sigmund wrote:
> > mention also compiler/ ? 
> 
> We are currently bundling DartC libraries as part of Dart Editor.
> We can continue to do so if they are not part of this sdk,
> although it would be more convenient if they were...

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode50
tools/create_sdk.py:50: corelib_sources =
(eval(open("corelib/src/corelib_sources.gypi").read()))['sources']
On 2011/12/02 22:45:13, sigmund wrote:
> 80 col here and below

Done.

http://codereview.chromium.org/8619005/diff/19001/tools/create_sdk.py#newcode64
tools/create_sdk.py:64: # Create and populate sdk/bin.
On 2011/12/02 22:45:13, sigmund wrote:
> also indent comments

Done.

[Ivan Posva, 2011-12-02 23:17:33]

LGTM with comment.

-Ivan

http://codereview.chromium.org/8619005/diff/23003/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/8619005/diff/23003/tools/create_sdk.py#newcode219
tools/create_sdk.py:219: # construct lib/core_runtimedart from whole cloth.
core_runtime.dart