Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 861773002: Perform access checks on the prototype chain when setting an element through a setter (Closed)

Created:
5 years, 11 months ago by Toon Verwaest
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Perform access checks on the prototype chain when setting an element through a setter BUG= Committed: https://crrev.com/65c01bdc64c85154a1c570c8f21a7fe24b3d9fee Cr-Commit-Position: refs/heads/master@{#26173}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/objects.cc View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 11 months ago (2015-01-20 15:19:16 UTC) #2
dcarney
lgtm
5 years, 11 months ago (2015-01-20 15:20:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861773002/20001
5 years, 11 months ago (2015-01-20 15:20:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-20 16:50:55 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:51:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65c01bdc64c85154a1c570c8f21a7fe24b3d9fee
Cr-Commit-Position: refs/heads/master@{#26173}

Powered by Google App Engine
This is Rietveld 408576698