Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 861753002: Add experimental v8 code cache options. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add experimental v8 code cache options. R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:399580 Committed: https://crrev.com/ed8d899eb98bfe386b6399a5900981377a098ef0 Cr-Commit-Position: refs/heads/master@{#312326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (1 generated)
Yang
5 years, 11 months ago (2015-01-20 12:17:19 UTC) #1
Yang
On 2015/01/20 12:17:19, Yang wrote: This corresponds to this blink CL: https://codereview.chromium.org/845923003/
5 years, 11 months ago (2015-01-20 12:17:39 UTC) #2
vogelheim
lgtm
5 years, 11 months ago (2015-01-20 12:26:54 UTC) #3
jochen (gone - plz use gerrit)
did the about:flags entry for this ever land? Do you need to update the options ...
5 years, 11 months ago (2015-01-20 13:09:28 UTC) #4
Yang
On 2015/01/20 13:09:28, jochen (slow) wrote: > did the about:flags entry for this ever land? ...
5 years, 11 months ago (2015-01-20 13:12:45 UTC) #5
vogelheim
On Tue, Jan 20, 2015 at 2:09 PM, <jochen@chromium.org> wrote: > > did the about:flags ...
5 years, 11 months ago (2015-01-20 13:41:21 UTC) #6
Yang
On 2015/01/20 13:41:21, vogelheim wrote: > On Tue, Jan 20, 2015 at 2:09 PM, <mailto:jochen@chromium.org> ...
5 years, 11 months ago (2015-01-20 13:43:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861753002/1
5 years, 11 months ago (2015-01-21 05:37:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 13:56:11 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:58:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed8d899eb98bfe386b6399a5900981377a098ef0
Cr-Commit-Position: refs/heads/master@{#312326}

Powered by Google App Engine
This is Rietveld 408576698