LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html - Issue 861743002: ServiceWorker: Test ServiceWorkerGlobalScope.registration attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html

Issue 861743002: ServiceWorker: Test ServiceWorkerGlobalScope.registration attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@expose_swreg2

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js » ('j') | LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html

diff --git a/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html b/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html

index 3ea489192f7243e499e99e1980c4d655cac4887d..fc4128f06de7b89dd5ed32838a2374f5c53fc3af 100644

--- a/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html

+++ b/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html

@@ -15,9 +15,18 @@ promise_test(function(t) {

})

.then(function() { return with_iframe(scope); })

.then(function(frame) {

+ var eventsSeen = [];

falken 2015/01/28 13:47:24 nit: events_seen, even better expected_events_seen

nhiroki 2015/01/28 14:25:05 Done.

+ eventsSeen.push('updatefound');

+ eventsSeen.push('install');

+ eventsSeen.push('statechange(installed)');

+ eventsSeen.push('statechange(activating)');

+ eventsSeen.push('activate');

+ eventsSeen.push('statechange(activated)');

+ eventsSeen.push('fetch');

assert_equals(

frame.contentDocument.body.textContent,

- 'PASS',

+ eventsSeen.toString(),

'Service Worker should respond to fetch');

frame.remove();

return service_worker_unregister_and_done(t, scope);