Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 861743002: ServiceWorker: Test ServiceWorkerGlobalScope.registration attribute (Closed)

Created:
5 years, 11 months ago by nhiroki
Modified:
5 years, 10 months ago
Reviewers:
kinuko, falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@expose_swreg2
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Test ServiceWorkerGlobalScope.registration attribute This tests... (1) version attributes (.installing, .waiting, .activate), (2) updatefound event, (3) statechange event, and (4) those event order. BUG=437677 TEST=run-webkit-tests http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189116

Patch Set 1 : #

Total comments: 4

Patch Set 2 : s/eventsSeen/events_seen/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -14 lines) Patch
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html View 1 1 chunk +11 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js View 1 2 chunks +92 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nhiroki
Ptal, thanks!
5 years, 11 months ago (2015-01-27 15:55:07 UTC) #5
kinuko
lgtm
5 years, 10 months ago (2015-01-28 12:27:36 UTC) #6
falken
lgtm too https://codereview.chromium.org/861743002/diff/60001/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html File LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html (right): https://codereview.chromium.org/861743002/diff/60001/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html#newcode18 LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html:18: var eventsSeen = []; nit: events_seen, even ...
5 years, 10 months ago (2015-01-28 13:47:24 UTC) #7
nhiroki
Thank you for reviewing. https://codereview.chromium.org/861743002/diff/60001/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html File LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html (right): https://codereview.chromium.org/861743002/diff/60001/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html#newcode18 LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html:18: var eventsSeen = []; On ...
5 years, 10 months ago (2015-01-28 14:25:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861743002/80001
5 years, 10 months ago (2015-01-28 15:03:14 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 16:19:06 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189116

Powered by Google App Engine
This is Rietveld 408576698