Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart

Issue 861713002: Handle super-method invocations in CPS->JS backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/backend_dart/sexpr_test.dart ('k') | tests/compiler/dart2js/js_backend_cps_ir.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
diff --git a/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart b/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
index bf5f024f21d075fe58fb37728b40ab5341319f32..eabbfa57b8b3324a8ccc5e15f45def46ef745ded 100644
--- a/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
+++ b/tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart
@@ -121,7 +121,7 @@ class SExpressionUnstringifier {
static const String INVOKE_CONTINUATION = "InvokeContinuation";
static const String INVOKE_CONTINUATION_RECURSIVE = "InvokeContinuation*";
static const String INVOKE_STATIC = "InvokeStatic";
- static const String INVOKE_SUPER_METHOD = "InvokeSuperMethod";
+ static const String INVOKE_METHOD_DIRECTLY = "InvokeMethodDirectly";
static const String INVOKE_METHOD = "InvokeMethod";
static const String LET_PRIM = "LetPrim";
static const String LET_CONT = "LetCont";
@@ -227,8 +227,8 @@ class SExpressionUnstringifier {
return parseInvokeMethod();
case INVOKE_STATIC:
return parseInvokeStatic();
- case INVOKE_SUPER_METHOD:
- return parseInvokeSuperMethod();
+ case INVOKE_METHOD_DIRECTLY:
+ return parseInvokeMethodDirectly();
case LET_PRIM:
return parseLetPrim();
case LET_CONT:
@@ -438,9 +438,12 @@ class SExpressionUnstringifier {
return new InvokeStatic(entity, selector, cont, args);
}
- /// (InvokeSuperMethod method (args) cont)
- InvokeSuperMethod parseInvokeSuperMethod() {
- tokens.consumeStart(INVOKE_SUPER_METHOD);
+ /// (InvokeMethodDirectly receiver method (args) cont)
+ InvokeMethodDirectly parseInvokeMethodDirectly() {
+ tokens.consumeStart(INVOKE_METHOD_DIRECTLY);
+
+ Definition receiver = name2variable[tokens.read()];
+ assert(receiver != null);
String methodName = tokens.read();
@@ -450,8 +453,9 @@ class SExpressionUnstringifier {
assert(cont != null);
tokens.consumeEnd();
+ Element element = new DummyElement(methodName);
Selector selector = dummySelector(methodName, args.length);
- return new InvokeSuperMethod(selector, cont, args);
+ return new InvokeMethodDirectly(receiver, element, selector, cont, args);
}
// (rec? name (args) body)
« no previous file with comments | « tests/compiler/dart2js/backend_dart/sexpr_test.dart ('k') | tests/compiler/dart2js/js_backend_cps_ir.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698