Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 861713002: Handle super-method invocations in CPS->JS backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index cf32d70856c138f45ef28b62ea2febc98da253af..23dcd7db16b50e09b4c50ad539513660f00414f2 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -181,6 +181,7 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
@override
js.Expression visitInvokeConstructor(tree_ir.InvokeConstructor node) {
if (node.constant != null) return giveup(node);
+ registry.registerInstantiatedClass(node.target.enclosingClass);
return buildStaticInvoke(node.selector,
node.target,
visitArguments(node.arguments));
@@ -213,9 +214,13 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
}
@override
- js.Expression visitInvokeSuperMethod(tree_ir.InvokeSuperMethod node) {
- return giveup(node);
- // TODO: implement visitInvokeSuperMethod
+ js.Expression visitInvokeMethodDirectly(tree_ir.InvokeMethodDirectly node) {
+ registry.registerDirectInvocation(node.target.declaration);
+ return js.js('#.#.call(#, #)',
+ [glue.prototypeAccess(node.target.enclosingClass),
+ glue.invocationName(node.selector),
+ visitExpression(node.receiver),
+ visitArguments(node.arguments)]);
}
@override
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698