pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart - Issue 861713002: Handle super-method invocations in CPS->JS backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 861713002: Handle super-method invocations in CPS->JS backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/codegen/unsugar.dart ('K') | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | pkg/compiler/lib/src/use_unused_api.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

index 9620b57f7967cf3278381fa64ada27385dbc9495..9d9df5679006d797dcc9c5322aa5d80b8bd59126 100644

--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

@@ -333,10 +333,12 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {

return "$receiver.$name($args)";

}

- String visitInvokeSuperMethod(InvokeSuperMethod node) {

+ String visitInvokeMethodDirectly(InvokeMethodDirectly node) {

+ String receiver = visitExpression(node.receiver);

+ String host = node.target.enclosingClass.name;

String name = node.selector.name;

String args = formatArguments(node);

- return "super.$name($args)";

+ return "$receiver.$host::$name($args)";

}

String visitInvokeConstructor(InvokeConstructor node) {