chrome/browser/resources/pdf/elements/page-selector/page-selector.html - Issue 861673002: Implement Page Selection in PDF Toolbar

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/pdf/elements/page-selector/page-selector.html

Issue 861673002: Implement Page Selection in PDF Toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pdf-toolbar

Patch Set: Implement Raymes' suggestions Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/pdf/elements/page-selector/page-selector.css ('K') | « chrome/browser/resources/pdf/elements/page-selector/page-selector.css ('k') | chrome/browser/resources/pdf/elements/page-selector/page-selector.js » ('j') | chrome/browser/resources/pdf/elements/page-selector/page-selector.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/paper-input/paper-input.html ">

	3

	4 <polymer-element name="page-selector" attributes="pageNo docLength chosenPageNo" >
	benwells 2015/01/27 02:01:41 Is there no line length limit in html? Is there no line length limit in html? Alexandre Carlton 2015/01/27 04:04:54 The Google style guide doesn't specify anything ab Show quoted text On 2015/01/27 02:01:41, benwells wrote: > Is there no line length limit in html? The Google style guide doesn't specify anything about line length, and the linter did not pick anything up. I've set it to 80 characters for now.
	5 <template>
	benwells 2015/01/27 02:10:56 Should this template tag and the script tag be ind Should this template tag and the script tag be indented? Alexandre Carlton 2015/01/27 04:04:54 Other viewer-elements (e.g. viewer-button.html) do Show quoted text On 2015/01/27 02:10:56, benwells wrote: > Should this template tag and the script tag be indented? Other viewer-elements (e.g. viewer-button.html) do not indent the <template> and <script> tags. benwells 2015/01/27 04:54:51 Ah. Another change of yours I think I just lg'd ha Show quoted text On 2015/01/27 04:04:54, Alexandre Carlton wrote: > On 2015/01/27 02:10:56, benwells wrote: > > Should this template tag and the script tag be indented? > > Other viewer-elements (e.g. viewer-button.html) do not indent the <template> and > <script> tags. Ah. Another change of yours I think I just lg'd had them indented. Alexandre Carlton 2015/01/27 05:34:50 That was in Issue 864753002, I'll fix that now. Show quoted text On 2015/01/27 04:54:51, benwells wrote: > On 2015/01/27 04:04:54, Alexandre Carlton wrote: > > On 2015/01/27 02:10:56, benwells wrote: > > > Should this template tag and the script tag be indented? > > > > Other viewer-elements (e.g. viewer-button.html) do not indent the <template> > and > > <script> tags. > > Ah. Another change of yours I think I just lg'd had them indented. That was in Issue 864753002, I'll fix that now.
	6 <link rel="stylesheet" href="page-selector.css">

	7 <paper-input value="{{pageNo}}" committedValue="{{chosenPageNo}}" id="pagesele ctor"></paper-input>
	benwells 2015/01/27 02:01:41 Same here. Is this valid html style? Same here. Is this valid html style?
	8 <span id="pagelength">/ {{docLength}}</span>

	9 </template>

	10 <script src="page-selector.js"></script>

	11 </polymer-element>

OLD	NEW