chrome/browser/resources/pdf/elements/page-selector/page-selector.html - Issue 861673002: Implement Page Selection in PDF Toolbar

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/pdf/elements/page-selector/page-selector.html

Issue 861673002: Implement Page Selection in PDF Toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pdf-toolbar

Patch Set: Implement Sam's review Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">
	raymes 2015/01/22 22:31:55 do you need this? Will it get included in the top do you need this? Will it get included in the top level page? Or should it be included here as well Alexandre Carlton 2015/01/22 22:50:29 The tutorial (https://www.polymer-project.org/docs Show quoted text On 2015/01/22 22:31:55, raymes wrote: > do you need this? Will it get included in the top level page? Or should it be > included here as well The tutorial (https://www.polymer-project.org/docs/start/tutorial/step-2.html) imports polymer.html in the custom element, though it does not do so in index.html. Where should polymer.html be imported?
	2 <link rel="import" href="chrome://resources/polymer/paper-input/paper-input.html ">

	3

	4 <polymer-element name="page-selector" attributes="pageNo docLength chosenPageNo" >

	5 <template>

	6 <link rel="stylesheet" href="page-selector.css">

	7 <paper-input value="{{pageNo}}" committedValue="{{chosenPageNo}}" id="pagesele ctor"></paper-input>

	8 <span id="pagelength">/ {{docLength}}</span>

	9 </template>

	10 <script src="page-selector.js"></script>

	11 </polymer-element>

OLD	NEW