Implement Page Selection in PDF Toolbar

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 93 matching lines @@
   for (var header in this.streamDetails_.responseHeaders) {
     headers += header + ': ' +
         this.streamDetails_.responseHeaders[header] + '\n';
   }
   this.plugin_.setAttribute('headers', headers);
 
   if (!this.streamDetails_.embedded)
     this.plugin_.setAttribute('full-frame', '');
   document.body.appendChild(this.plugin_);
 
+  this.pageIndicator_.addEventListener('changePage', function(e) {
+    this.viewport_.goToPage(e.detail.page);
+  }.bind(this));
+
   // Setup the button event listeners.
   $('fit-to-width-button').addEventListener('click',
       this.viewport_.fitToWidth.bind(this.viewport_));
   $('fit-to-page-button').addEventListener('click',
       this.viewport_.fitToPage.bind(this.viewport_));
   $('zoom-in-button').addEventListener('click',
       this.viewport_.zoomIn.bind(this.viewport_));
   $('zoom-out-button').addEventListener('click',
       this.viewport_.zoomOut.bind(this.viewport_));
   $('save-button').addEventListener('click', this.save_.bind(this));
@@ skipping 160 matching lines @@
    * Notify the plugin to save.
    */
   save_: function() {
     this.plugin_.postMessage({
       type: 'save'
     });
   },
 
   /**
    * @private
+   * Advance the page.
+   */
+  goToNextPage_: function() {

[Sam McNally, 2015/01/21 04:03:38]

Are these used?

[Alexandre Carlton, 2015/01/21 05:20:35]

Removed.

+    var currentPage = this.viewport_.getMostVisiblePage();
+    this.viewport_.goToPage(currentPage + 1);
+  },
+
+  /**
+   * @private
+   * Go back a page.
+   */
+  goToPreviousPage_: function() {
+    var currentPage = this.viewport_.getMostVisiblePage();
+    this.viewport_.goToPage(currentPage - 1);
+  },
+
+  /**
+   * @private
    * Handle open pdf parameters. This function updates the viewport as per
    * the parameters mentioned in the url while opening pdf. The order is
    * important as later actions can override the effects of previous actions.
    */
   handleURLParams_: function() {
     var urlParams =
         this.paramsParser_.getViewportFromUrlParams(
             this.streamDetails_.originalUrl);
     if (urlParams.page)
       this.viewport_.goToPage(urlParams.page);
@@ skipping 26 matching lines @@
       this.sizer_.style.display = 'none';
       this.toolbar_.style.visibility = 'hidden';
       if (this.passwordScreen_.active) {
         this.passwordScreen_.deny();
         this.passwordScreen_.active = false;
       }
     } else if (progress == 100) {
       // Document load complete.
       if (this.lastViewportPosition_)
         this.viewport_.position = this.lastViewportPosition_;
+      if (this.isMaterial_)
+        this.pageIndicator_.style.visibility = 'visible';
       this.handleURLParams_();
       this.loaded_ = true;
       this.sendScriptingMessage_({
         type: 'documentLoaded'
       });
     }
   },
 
   /**
    * @private
@@ skipping 78 matching lines @@
   handlePluginMessage_: function(message) {
     switch (message.data.type.toString()) {
       case 'documentDimensions':
         this.documentDimensions_ = message.data;
         this.viewport_.setDocumentDimensions(this.documentDimensions_);
         // If we received the document dimensions, the password was good so we
         // can dismiss the password screen.
         if (this.passwordScreen_.active)
           this.passwordScreen_.accept();
 
-        this.pageIndicator_.initialFadeIn();
+        if (this.isMaterial_) {
+            this.pageIndicator_.docLength =

[Sam McNally, 2015/01/21 04:03:38]

Indentation.

[Alexandre Carlton, 2015/01/21 05:20:35]

Done.

+                this.documentDimensions_.pageDimensions.length;
+        } else {
+            this.pageIndicator_.initialFadeIn();
+        }
+
         this.toolbar_.initialFadeIn();
         break;
       case 'email':
         var href = 'mailto:' + message.data.to + '?cc=' + message.data.cc +
             '&bcc=' + message.data.bcc + '&subject=' + message.data.subject +
             '&body=' + message.data.body;
         window.location.href = href;
         break;
       case 'getAccessibilityJSONReply':
         this.sendScriptingMessage_(message.data);
@@ skipping 135 matching lines @@
     this.toolbar_.style.bottom = toolbarBottom + 'px';
     // Hide the toolbar if it doesn't fit in the viewport.
     if (this.toolbar_.offsetLeft < 0 || this.toolbar_.offsetTop < 0)
       this.toolbar_.style.visibility = 'hidden';
     else
       this.toolbar_.style.visibility = 'visible';
 
     // Update the page indicator.
     var visiblePage = this.viewport_.getMostVisiblePage();
     this.pageIndicator_.index = visiblePage;
-    if (this.documentDimensions_.pageDimensions.length > 1 &&
-        hasScrollbars.vertical) {
-      this.pageIndicator_.style.visibility = 'visible';
-    } else {
-      this.pageIndicator_.style.visibility = 'hidden';
+    if (!this.isMaterial_) {
+      if (this.documentDimensions_.pageDimensions.length > 1 &&
+          hasScrollbars.vertical) {
+        this.pageIndicator_.style.visibility = 'visible';
+      } else {
+        this.pageIndicator_.style.visibility = 'hidden';
+      }
     }
 
     var visiblePageDimensions = this.viewport_.getPageScreenRect(visiblePage);
     var size = this.viewport_.size;
     this.sendScriptingMessage_({
       type: 'viewport',
       pageX: visiblePageDimensions.x,
       pageY: visiblePageDimensions.y,
       pageWidth: visiblePageDimensions.width,
       viewportWidth: size.width,
@@ skipping 93 matching lines @@
               this.streamDetails_.tabId != -1);
   },
 
   /**
    * @type {Viewport} the viewport of the PDF viewer.
    */
   get viewport() {
     return this.viewport_;
   }
 };