test/webkit/fast/js/toString-overrides-expected.txt - Issue 861623002: Add a pretty printer to improve the error message non-function calls

Side by Side Diff: test/webkit/fast/js/toString-overrides-expected.txt

Issue 861623002: Add a pretty printer to improve the error message non-function calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update test expectations Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« src/runtime/runtime-debug.cc ('K') | « test/webkit/exception-for-nonobject-expected.txt ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2013 the V8 project authors. All rights reserved.	1 # Copyright 2013 the V8 project authors. All rights reserved.

2 # Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.	2 # Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.

3 #	3 #

4 # Redistribution and use in source and binary forms, with or without	4 # Redistribution and use in source and binary forms, with or without

5 # modification, are permitted provided that the following conditions	5 # modification, are permitted provided that the following conditions

6 # are met:	6 # are met:

7 # 1. Redistributions of source code must retain the above copyright	7 # 1. Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # 2. Redistributions in binary form must reproduce the above copyright	9 # 2. Redistributions in binary form must reproduce the above copyright

10 # notice, this list of conditions and the following disclaimer in the	10 # notice, this list of conditions and the following disclaimer in the

(...skipping 10 matching lines...) Expand all Loading...
21 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS	21 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS

22 # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	22 # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

23	23

24 This test checks for regression against 4147: Array.toString() and toLocaleStrin g() improvements from KDE KJS.	24 This test checks for regression against 4147: Array.toString() and toLocaleStrin g() improvements from KDE KJS.

25	25

26 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".	26 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

27	27

28	28

29 PASS [1].toString() is '1'	29 PASS [1].toString() is '1'

30 PASS [1].toLocaleString() is 'toLocaleString'	30 PASS [1].toLocaleString() is 'toLocaleString'

31 FAIL [1].toLocaleString() should be 1. Threw exception TypeError: string is not a function	31 FAIL [1].toLocaleString() should be 1. Threw exception TypeError: (intermediate value).toLocaleString is not a function
	caitp (gmail) 2015/01/19 16:44:58 Just my opinion, but I think `(intermediate value) Just my opinion, but I think `(intermediate value).toLocaleString is not a function` feels less informative than the old error For code like `a.b()` where b is a string, it would be nice if the error was more like "TypeError() `a.b` (string "toLocaleString") is not a function".
32 PASS [/r/].toString() is 'toString2'	32 PASS [/r/].toString() is 'toString2'

33 PASS [/r/].toLocaleString() is 'toLocaleString2'	33 PASS [/r/].toLocaleString() is 'toLocaleString2'

34 FAIL [/r/].toLocaleString() should be toString2. Threw exception TypeError: stri ng is not a function	34 FAIL [/r/].toLocaleString() should be toString2. Threw exception TypeError: (int ermediate value).toLocaleString is not a function

35 PASS caught is true	35 PASS caught is true

36 PASS successfullyParsed is true	36 PASS successfullyParsed is true

37	37

38

39 TEST COMPLETE	38 TEST COMPLETE

40	39

OLD	NEW