Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 861553008: Add perspective divide when we're mapping down to a 2D varying (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add perspective divide when we're mapping down to a 2D varying This fixes a few of the perspective errors in SampleApp but not all. BUG=skia:3326 Committed: https://skia.googlesource.com/skia/+/3e3b58d57a358e2d52bc23ad2409a95d59310100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/GrGeometryProcessor.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
5 years, 11 months ago (2015-01-20 22:20:52 UTC) #2
bsalomon
lgtm
5 years, 11 months ago (2015-01-20 22:21:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861553008/1
5 years, 11 months ago (2015-01-20 22:30:33 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 22:37:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e3b58d57a358e2d52bc23ad2409a95d59310100

Powered by Google App Engine
This is Rietveld 408576698