Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 861523002: Updated parsing of PrivetV3 mDns record. (Closed)

Created:
5 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated parsing of PrivetV3 mDns record. DeviceDescription::id is set from "gcd_id" value. DeviceDescription::type is set from "class" value. Removed some unused values. BUG=449864 Committed: https://crrev.com/1401303543b58c944e7be07f0f8cfabe361093b7 Cr-Commit-Position: refs/heads/master@{#313150}

Patch Set 1 #

Patch Set 2 : Thu 01/22/2015 2:13:36.25 #

Patch Set 3 : Thu 01/22/2015 10:12:17.07 #

Patch Set 4 : Thu 01/22/2015 10:13:15.59 #

Patch Set 5 : Thu 01/22/2015 10:30:09.39 #

Patch Set 6 : Thu 01/22/2015 10:42:57.49 #

Total comments: 6

Patch Set 7 : Mon Jan 26 13:26:30 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -74 lines) Patch
M chrome/browser/local_discovery/device_description.h View 1 2 3 4 5 1 chunk +2 lines, -14 lines 0 comments Download
M chrome/browser/local_discovery/device_description.cc View 1 2 3 4 5 6 1 chunk +25 lines, -48 lines 0 comments Download
M chrome/browser/local_discovery/privet_constants.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_constants.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_device_lister_impl.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/privet_device_lister_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_device_resolver.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vitaly Buka (NO REVIEWS)
5 years, 11 months ago (2015-01-22 18:14:35 UTC) #2
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/861523002/diff/100001/chrome/browser/local_discovery/device_description.cc File chrome/browser/local_discovery/device_description.cc (right): https://codereview.chromium.org/861523002/diff/100001/chrome/browser/local_discovery/device_description.cc#newcode20 chrome/browser/local_discovery/device_description.cc:20: std::string prefix = name + "="; const std::string ...
5 years, 11 months ago (2015-01-26 21:04:48 UTC) #4
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/861523002/diff/100001/chrome/browser/local_discovery/device_description.cc File chrome/browser/local_discovery/device_description.cc (right): https://codereview.chromium.org/861523002/diff/100001/chrome/browser/local_discovery/device_description.cc#newcode20 chrome/browser/local_discovery/device_description.cc:20: std::string prefix = name + "="; On 2015/01/26 21:04:47, ...
5 years, 11 months ago (2015-01-26 21:27:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861523002/120001
5 years, 11 months ago (2015-01-26 21:28:22 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 11 months ago (2015-01-26 22:13:00 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 22:14:03 UTC) #9
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/1401303543b58c944e7be07f0f8cfabe361093b7
Cr-Commit-Position: refs/heads/master@{#313150}

Powered by Google App Engine
This is Rietveld 408576698