Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 861413003: skeleton GYP for CAPS (Closed)

Created:
5 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

skeleton GYP for CAPS CAPS is a regular win32 exe. BUG=447073 Committed: https://crrev.com/9f4414bd26adba61acfb04c542774447b6dd9628 Cr-Commit-Position: refs/heads/master@{#312551}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/caps.gyp View 1 chunk +59 lines, -0 lines 0 comments Download
A chrome/tools/crash_service/caps/caps.ver View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/tools/crash_service/caps/main_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
cpu_(ooo_6.6-7.5)
ptal https://codereview.chromium.org/861413003/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/861413003/diff/1/build/all.gyp#newcode229 build/all.gyp:229: ], I don't know what I am doing. ...
5 years, 11 months ago (2015-01-22 00:25:18 UTC) #2
scottmg
lgtm if a binary builds and the version info looks correct in 'Properties'. https://codereview.chromium.org/861413003/diff/1/build/all.gyp File ...
5 years, 11 months ago (2015-01-22 00:30:47 UTC) #3
cpu_(ooo_6.6-7.5)
this is how it looks VS_VERSION_INFO VERSIONINFO FILEVERSION 42,0,2283,0 PRODUCTVERSION 42,0,2283,0 FILEFLAGSMASK 0x17L #ifdef _DEBUG ...
5 years, 11 months ago (2015-01-22 01:26:16 UTC) #4
scottmg
heh: https://code.google.com/p/chromium/codesearch#search/&q=LegalCopyright&sq=package:chromium&type=cs Looks reasonable though. On Wed, Jan 21, 2015 at 5:26 PM, <cpu@chromium.org> wrote: ...
5 years, 11 months ago (2015-01-22 01:27:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861413003/20001
5 years, 11 months ago (2015-01-22 01:51:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 03:16:03 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 03:18:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f4414bd26adba61acfb04c542774447b6dd9628
Cr-Commit-Position: refs/heads/master@{#312551}

Powered by Google App Engine
This is Rietveld 408576698