Remove staging SkStream::unref().

Remove staging SkStream::unref().

SkStream::unref() was added to ease transitioning off of SkStream
deriving from SkRefCnt. It is no longer needed, remove it.

TBR=reed@google.com

Committed: https://skia.googlesource.com/skia/+/2dca817edb0d741b7d8930009417bf9bd071808d

[bungeman-skia, 2015-01-21 23:53:39]

bungeman@google.com changed reviewers:
+ scroggo@google.com

[bungeman-skia, 2015-01-21 23:53:40]

Note that this cannot / should not land until after
https://codereview.chromium.org/860383006/ has landed and rolled into Chromium.

[bungeman-skia, 2015-01-22 04:00:35]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-01-22 04:01:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861413002/1

[commit-bot: I haz the power, 2015-01-22 04:01:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-22 10:01 UTC

[commit-bot: I haz the power, 2015-01-22 04:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 04:01:19]

Presubmit check for 861413002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[bungeman-skia, 2015-01-22 04:02:35]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-01-22 04:03:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861413002/1

[commit-bot: I haz the power, 2015-01-22 04:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 04:08:16]

Try jobs failed on following builders:
  Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86...)

[bungeman-skia, 2015-01-22 04:40:07]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-01-22 04:40:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861413002/20001

[commit-bot: I haz the power, 2015-01-22 04:48:47]

This issue passed the CQ. To commit it, remove "COMMIT=false" from
the description and try again.

[scroggo, 2015-01-22 13:55:36]

Thanks for fixing these!

I have some inline comments, which apply to problems from before this CL.

lgtm with or without fixing those.

https://codereview.chromium.org/861413002/diff/20001/include/utils/win/SkIStr...
File include/utils/win/SkIStream.h (right):

https://codereview.chromium.org/861413002/diff/20001/include/utils/win/SkIStr...
include/utils/win/SkIStream.h:78: * A minimal read-only IStream implementation
which wraps an SkIStream.
nit: wraps an SkStream

https://codereview.chromium.org/861413002/diff/20001/include/utils/win/SkIStr...
include/utils/win/SkIStream.h:83: bool fDeleteOnRelease;
Could be const?

https://codereview.chromium.org/861413002/diff/20001/src/utils/win/SkIStream.cpp
File src/utils/win/SkIStream.cpp (right):

https://codereview.chromium.org/861413002/diff/20001/src/utils/win/SkIStream....
src/utils/win/SkIStream.cpp:116: if (this->fSkStream && fDeleteOnRelease) {
It appears fSkStream can never be NULL, so this can just be

if (fDeleteOnRelease) {

[bungeman-skia, 2015-01-22 14:07:31]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-01-22 14:08:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861413002/20001

[commit-bot: I haz the power, 2015-01-22 14:08:35]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2dca817edb0d741b7d8930009417bf9bd071808d

[bungeman-skia, 2015-01-22 14:08:52]

On 2015/01/22 13:55:36, scroggo wrote:
> Thanks for fixing these!
> 
> I have some inline comments, which apply to problems from before this CL.
> 
> lgtm with or without fixing those.
> 
>
https://codereview.chromium.org/861413002/diff/20001/include/utils/win/SkIStr...
> File include/utils/win/SkIStream.h (right):
> 
>
https://codereview.chromium.org/861413002/diff/20001/include/utils/win/SkIStr...
> include/utils/win/SkIStream.h:78: * A minimal read-only IStream implementation
> which wraps an SkIStream.
> nit: wraps an SkStream
> 
>
https://codereview.chromium.org/861413002/diff/20001/include/utils/win/SkIStr...
> include/utils/win/SkIStream.h:83: bool fDeleteOnRelease;
> Could be const?
> 
>
https://codereview.chromium.org/861413002/diff/20001/src/utils/win/SkIStream.cpp
> File src/utils/win/SkIStream.cpp (right):
> 
>
https://codereview.chromium.org/861413002/diff/20001/src/utils/win/SkIStream....
> src/utils/win/SkIStream.cpp:116: if (this->fSkStream && fDeleteOnRelease) {
> It appears fSkStream can never be NULL, so this can just be
> 
> if (fDeleteOnRelease) {

Good points, will fix these today.