content/browser/storage_partition_impl.cc - Issue 861373002: Refactor navigator.connect code to make it more flexible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/storage_partition_impl.cc

Issue 861373002: Refactor navigator.connect code to make it more flexible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lower similarity threshold Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/browser/storage_partition_impl_map.cc » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/storage_partition_impl.cc

diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage_partition_impl.cc

index e6a556197310c47e1785b2bb5ae6e0955367495e..9216fb9dabcb8565a6cf193bb25797fecf863490 100644

--- a/content/browser/storage_partition_impl.cc

+++ b/content/browser/storage_partition_impl.cc

@@ -11,7 +11,8 @@

#include "content/browser/geofencing/geofencing_manager.h"

#include "content/browser/gpu/shader_disk_cache.h"

#include "content/browser/host_zoom_map_impl.h"

-#include "content/browser/navigator_connect/navigator_connect_context.h"

+#include "content/browser/navigator_connect/navigator_connect_context_impl.h"

+#include "content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h"

#include "content/common/dom_storage/dom_storage_types.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_thread.h"

@@ -491,7 +492,9 @@ StoragePartitionImpl* StoragePartitionImpl::Create(

context->CreateZoomLevelDelegate(partition_path)));

scoped_refptr<NavigatorConnectContext> navigator_connect_context =

- new NavigatorConnectContext(service_worker_context);

+ new NavigatorConnectContextImpl();

+ navigator_connect_context->AddFactory(make_scoped_ptr(

+ new NavigatorConnectServiceWorkerServiceFactory(service_worker_context)));

StoragePartitionImpl* storage_partition = new StoragePartitionImpl(

context, partition_path, quota_manager.get(), appcache_service.get(),