Make ppapi TestView use default browser test timeouts rather than internal ones

Make ppapi TestView use default browser test timeouts rather than internal ones

BUG=450908
Committed: https://crrev.com/54c4e4ade1f80731d83470dcbe7c0e260a992703
Cr-Commit-Position: refs/heads/master@{#313670}

[raymes, 2015-01-28 02:18:09]

raymes@chromium.org changed reviewers:
+ benwells@chromium.org, dmichael@chromium.org

[benwells, 2015-01-28 02:55:50]

https://codereview.chromium.org/861343005/diff/1/ppapi/tests/test_view.cc
File ppapi/tests/test_view.cc (right):

https://codereview.chromium.org/861343005/diff/1/ppapi/tests/test_view.cc#new...
ppapi/tests/test_view.cc:59: kViewChangeTimeoutSec * 1000, timeout);
Can this be removed as well?

[raymes, 2015-01-28 03:34:34]

David: Do you know why these timeouts are here?

On 2015/01/28 02:55:50, benwells wrote:
> https://codereview.chromium.org/861343005/diff/1/ppapi/tests/test_view.cc
> File ppapi/tests/test_view.cc (right):
> 
>
https://codereview.chromium.org/861343005/diff/1/ppapi/tests/test_view.cc#new...
> ppapi/tests/test_view.cc:59: kViewChangeTimeoutSec * 1000, timeout);
> Can this be removed as well?

Done.

[benwells, 2015-01-28 03:36:51]

lgtm, thanks!

[dmichael (off chromium), 2015-01-28 17:50:32]

Thanks! lgtm, but I think benwells is right; we should get rid of the other use
of the timeout and the QuitMessageLoop event.

https://codereview.chromium.org/861343005/diff/1/ppapi/tests/test_view.cc
File ppapi/tests/test_view.cc (right):

https://codereview.chromium.org/861343005/diff/1/ppapi/tests/test_view.cc#new...
ppapi/tests/test_view.cc:59: kViewChangeTimeoutSec * 1000, timeout);
On 2015/01/28 02:55:50, benwells wrote:
> Can this be removed as well?
I'm not super familiar with this test, but the pattern here is to quit the
message loop if we haven't received the View event within 5 seconds.

With the code as it is in this CL, we'll just drop back in to the loop and try
again anyway. So there seems to be no point in this QuitMessageLoop event.

We can just rely on the test framework to kill the test if it hangs.

[raymes, 2015-01-29 05:01:52]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-01-29 05:02:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861343005/20001

[commit-bot: I haz the power, 2015-01-29 06:10:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-29 06:11:44]

Patchset 2 (id:??) landed as
https://crrev.com/54c4e4ade1f80731d83470dcbe7c0e260a992703
Cr-Commit-Position: refs/heads/master@{#313670}