Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 861303003: Don't test pipe modes nobody uses. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't test pipe modes nobody uses. SkDeferredCanvas uses a simple pipe: no cross-process, no shared-address, etc. (see src/utils/SkDeferredCanvas.cpp:306). We could just remove these modes from the bot configs, but I'd like to take the opportunity to simplify the DM code too. I'll happily volunteer to put things back should we decide we want to test these modes. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7edca21226017e6b87a0c95fa571d34c36ceca04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M dm/DM.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M dm/DMSrcSink.h View 1 chunk +1 line, -2 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 11 months ago (2015-01-21 21:12:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861303003/1
5 years, 11 months ago (2015-01-21 21:12:36 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-21 21:12:37 UTC) #5
scroggo
On 2015/01/21 21:12:37, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 11 months ago (2015-01-21 21:15:49 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 21:18:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7edca21226017e6b87a0c95fa571d34c36ceca04

Powered by Google App Engine
This is Rietveld 408576698