Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 8613007: Adds logic to bump up the default heap for invoking dartc on Mac. (Closed)

Created:
9 years, 1 month ago by zundel
Modified:
9 years ago
Reviewers:
mmendez
CC:
reviews_dartlang.org, Mads Ager (google)
Visibility:
Public.

Description

Adds logic to bump up the default heap for invoking dartc on Mac.

Patch Set 1 #

Patch Set 2 : Don't copy things blindly from stackoverflow #

Total comments: 1

Patch Set 3 : Reverted UnitTestBatchRunner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M compiler/scripts/dartc.sh View 1 1 chunk +8 lines, -1 line 0 comments Download
M compiler/scripts/dartc_test.sh View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
zundel
9 years, 1 month ago (2011-11-22 13:08:29 UTC) #1
zundel
9 years, 1 month ago (2011-11-22 13:09:06 UTC) #2
zundel
See issue 173: http://code.google.com/p/dart/issues/detail?id=173
9 years, 1 month ago (2011-11-22 13:30:46 UTC) #3
ahe
I thought we were getting rid of the --optimize option? http://codereview.chromium.org/8613007/diff/2001/compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java File compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java (right): http://codereview.chromium.org/8613007/diff/2001/compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java#newcode53 ...
9 years, 1 month ago (2011-11-22 13:33:35 UTC) #4
zundel
9 years, 1 month ago (2011-11-22 14:15:04 UTC) #5
zundel
Srdjan ran some tests on Mac experimenting with heap size: ./tools/test.py --component dartc co19/LangSpecTest/13_Types/13_4_Interface_Types/A11/t01 -Xmx128m ...
9 years ago (2011-11-28 20:30:13 UTC) #6
ahe
I'd rather skip the problematic test and record it as a known issue. Last time ...
9 years ago (2011-11-28 21:06:59 UTC) #7
zundel
9 years ago (2011-11-29 16:57:12 UTC) #8
The running out of memory did turn out to be an architecture issue in Dartc.  We
didn't see it before because this test wasn't introduced until Oct31 and
possibly not integrated into the Dart build until sometime after that. I guess
no one ran all the tests on a mac until recently. 

I addressed the root cause in another change.  Taking the discussion in this
thread into account, I decided in this other CL to constrain heap for unit
testing to 128M on all platforms, and propose bumping up the memory for regular
dartc invocations to 256M.

closing this issue in favor of:
http://codereview.chromium.org/8659022/

Powered by Google App Engine
This is Rietveld 408576698