Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 861293002: Allow external applications to register for mojo: urls (Closed)

Created:
5 years, 11 months ago by DaveMoore
Modified:
5 years, 11 months ago
Reviewers:
Aaron Boodman
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow external applications to register for mojo: urls BUG= R=aa@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0504d06d6fad0c811a8880d07dc58faf7450f641

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Patch Set 3 : Merge / nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -17 lines) Patch
M shell/application_manager/application_manager.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M shell/application_manager/application_manager.cc View 1 2 3 chunks +34 lines, -17 lines 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 2 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
DaveMoore
Cleanup
5 years, 11 months ago (2015-01-21 18:34:22 UTC) #1
DaveMoore
5 years, 11 months ago (2015-01-21 18:34:51 UTC) #3
DaveMoore
5 years, 11 months ago (2015-01-22 20:34:06 UTC) #5
Aaron Boodman
I think this could be simplified relatively easily, but I don't know if it makes ...
5 years, 11 months ago (2015-01-22 20:52:42 UTC) #6
Aaron Boodman
lgtm in case you want to land this now
5 years, 11 months ago (2015-01-22 21:45:31 UTC) #7
DaveMoore
Merge / nits
5 years, 11 months ago (2015-01-23 23:30:42 UTC) #8
DaveMoore
5 years, 11 months ago (2015-01-23 23:33:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0504d06d6fad0c811a8880d07dc58faf7450f641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698