Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: test/win/linker-flags/safeseh.gyp

Issue 861273003: Reland "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers" (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/win/gyptest-link-safeseh.py ('k') | test/win/linker-flags/safeseh_zero64.asm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/linker-flags/safeseh.gyp
diff --git a/test/win/linker-flags/safeseh.gyp b/test/win/linker-flags/safeseh.gyp
index 61036200519e332cdf9a9ad296d5465f2bc177a5..d4a62074b8f94c1fa33c7ffc95a2db78603f9d2f 100644
--- a/test/win/linker-flags/safeseh.gyp
+++ b/test/win/linker-flags/safeseh.gyp
@@ -3,11 +3,28 @@
# found in the LICENSE file.
{
- 'targets': [
+ 'target_defaults': {
+ 'configurations': {
+ 'Default': {
+ 'msvs_configuration_platform': 'Win32',
+ },
+ 'Default_x64': {
+ 'inherit_from': ['Default'],
+ 'msvs_configuration_platform': 'x64',
+ },
+ },
+ },
+ 'targets': [
{
'target_name': 'test_safeseh_default',
'type': 'executable',
'msvs_settings': {
+ # By default, msvs passes /SAFESEH for Link, but not for MASM. In
+ # order for test_safeseh_default to link successfully, we need to
+ # explicitly specify /SAFESEH for MASM.
+ 'MASM': {
+ 'UseSafeExceptionHandlers': 'true',
+ },
},
'sources': [
'safeseh_hello.cc',
@@ -43,5 +60,20 @@
'safeseh_zero.asm',
],
},
+ {
+ # x64 targets cannot have ImageHasSafeExceptionHandlers or
+ # UseSafeExceptionHandlers set.
+ 'target_name': 'test_safeseh_x64',
+ 'type': 'executable',
+ 'configurations': {
+ 'Default': {
+ 'msvs_target_platform': 'x64',
+ },
+ },
+ 'sources': [
+ 'safeseh_hello.cc',
+ 'safeseh_zero64.asm',
+ ],
+ },
]
}
« no previous file with comments | « test/win/gyptest-link-safeseh.py ('k') | test/win/linker-flags/safeseh_zero64.asm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698