pylib/gyp/win_tool.py - Issue 861273003: Reland "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/win_tool.py

Issue 861273003: Reland "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers" (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/win_tool.py

diff --git a/pylib/gyp/win_tool.py b/pylib/gyp/win_tool.py

index ac15d737277dd83226912c11f2f0732bd0cad54b..417e465f7853f4690bdda25bb1c501c230b68697 100755

--- a/pylib/gyp/win_tool.py

+++ b/pylib/gyp/win_tool.py

@@ -259,9 +259,6 @@ class WinTool(object):

def ExecAsmWrapper(self, arch, *args):

"""Filter logo banner from invocations of asm.exe."""

env = self._GetEnv(arch)

- # MSVS doesn't assemble x64 asm files.

- if arch == 'environment.x64':

- return 0

popen = subprocess.Popen(args, shell=True, env=env,

stdout=subprocess.PIPE, stderr=subprocess.STDOUT)

out, _ = popen.communicate()

« no previous file with comments | « pylib/gyp/msvs_emulation.py ('k') | test/win/gyptest-link-safeseh.py » ('j') | no next file with comments »