Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 861223002: Reland Make clang the default on linux. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Make clang the default on linux. BUG= Committed: https://crrev.com/72ef6843b0aff68e519a8f26e7d2f7dd87b4712c Cr-Commit-Position: refs/heads/master@{#26204}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Patch Set 3 : Improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
Michael Achenbach
PTAL - will make sure the linux32 builder is a 64 bit bot before landing...
5 years, 11 months ago (2015-01-21 15:23:53 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/861223002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/861223002/diff/1/build/standalone.gypi#newcode124 build/standalone.gypi:124: (v8_target_arch!="arm" or target_arch!="arm") and \ target_arch should be enough. ...
5 years, 11 months ago (2015-01-21 15:26:08 UTC) #3
Michael Achenbach
Done
5 years, 11 months ago (2015-01-21 15:30:34 UTC) #4
Michael Achenbach
Maybe I invert the logic to allow only x64 and ia32...
5 years, 11 months ago (2015-01-21 15:31:39 UTC) #5
jochen (gone - plz use gerrit)
On 2015/01/21 at 15:31:39, machenbach wrote: > Maybe I invert the logic to allow only ...
5 years, 11 months ago (2015-01-21 15:35:32 UTC) #6
Michael Achenbach
Done
5 years, 11 months ago (2015-01-21 16:07:47 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-21 16:14:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861223002/40001
5 years, 11 months ago (2015-01-21 19:01:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-21 19:32:10 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/72ef6843b0aff68e519a8f26e7d2f7dd87b4712c Cr-Commit-Position: refs/heads/master@{#26204}
5 years, 11 months ago (2015-01-21 19:32:21 UTC) #12
Michael Achenbach
5 years, 11 months ago (2015-01-21 20:37:08 UTC) #13

Powered by Google App Engine
This is Rietveld 408576698