Source/core/svg/SVGLengthContext.h - Issue 861213003: Fix problems with flakes in SVG LayoutTests by reordering arithmetic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGLengthContext.h

Issue 861213003: Fix problems with flakes in SVG LayoutTests by reordering arithmetic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated a text test too. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGLengthContext.h

diff --git a/Source/core/svg/SVGLengthContext.h b/Source/core/svg/SVGLengthContext.h

index fb7cf68ccb3652504e43382232a3f0b8e70bb57c..758cb6d93988def38c597b93d4bed46187517be3 100644

--- a/Source/core/svg/SVGLengthContext.h

+++ b/Source/core/svg/SVGLengthContext.h

@@ -72,7 +72,8 @@ public:

private:

float convertValueFromUserUnitsToPercentage(float value, SVGLengthMode, ExceptionState&) const;

float convertValueFromPercentageToUserUnits(float value, SVGLengthMode, ExceptionState&) const;

- static float convertValueFromPercentageToUserUnits(float value, SVGLengthMode, const FloatSize&);

+ static float convertValueFromPercentageToUserUnits(float value, SVGLengthMode, const FloatSize& viewportSize);

+ static float convertValueFromPercentageToUserUnits(const SVGLength& value, const FloatSize& viewportSize);

float convertValueFromUserUnitsToEMS(float value, ExceptionState&) const;

float convertValueFromEMSToUserUnits(float value, ExceptionState&) const;

« Source/core/svg/SVGLength.cpp ('K') | « Source/core/svg/SVGLength.cpp ('k') | Source/core/svg/SVGLengthContext.cpp » ('j') | Source/core/svg/SVGLengthContext.cpp » ('J')