Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp - Issue 861213003: Fix problems with flakes in SVG LayoutTests by reordering arithmetic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

Issue 861213003: Fix problems with flakes in SVG LayoutTests by reordering arithmetic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated a text test too. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

diff --git a/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp b/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

index dceefe5d35b9c7392718ccf28cc0581d732afc70..57c963fd83c7a70eac48c7da7617df66dd4a8c7d 100644

--- a/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

+++ b/Source/core/rendering/svg/SVGTextLayoutEngineBaseline.cpp

@@ -40,7 +40,7 @@ float SVGTextLayoutEngineBaseline::calculateBaselineShift(const SVGRenderStyle&

if (style.baselineShift() == BS_LENGTH) {

RefPtrWillBeRawPtr<SVGLength> baselineShiftValueLength = style.baselineShiftValue();

if (baselineShiftValueLength->unitType() == LengthTypePercentage)

- return baselineShiftValueLength->valueAsPercentage() * m_font.fontDescription().computedPixelSize();

+ return baselineShiftValueLength->scaleByPercentage(m_font.fontDescription().computedPixelSize());

SVGLengthContext lengthContext(contextElement);

return baselineShiftValueLength->value(lengthContext);

« no previous file with comments | « LayoutTests/svg/filters/parent-children-with-same-filter-expected.txt ('k') | Source/core/svg/SVGLength.h » ('j') | Source/core/svg/SVGLength.cpp » ('J')