Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: Source/core/svg/SVGLengthContext.h

Issue 861213003: Fix problems with flakes in SVG LayoutTests by reordering arithmetic. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rephrased comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGLength.cpp ('k') | Source/core/svg/SVGLengthContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 static float resolveLength(const SVGElement*, SVGUnitTypes::SVGUnitType, Pas sRefPtrWillBeRawPtr<SVGLength>); 65 static float resolveLength(const SVGElement*, SVGUnitTypes::SVGUnitType, Pas sRefPtrWillBeRawPtr<SVGLength>);
66 66
67 float convertValueToUserUnits(float, SVGLengthMode, SVGLengthType fromUnit, ExceptionState&) const; 67 float convertValueToUserUnits(float, SVGLengthMode, SVGLengthType fromUnit, ExceptionState&) const;
68 float convertValueFromUserUnits(float, SVGLengthMode, SVGLengthType toUnit, ExceptionState&) const; 68 float convertValueFromUserUnits(float, SVGLengthMode, SVGLengthType toUnit, ExceptionState&) const;
69 69
70 bool determineViewport(FloatSize&) const; 70 bool determineViewport(FloatSize&) const;
71 71
72 private: 72 private:
73 float convertValueFromUserUnitsToPercentage(float value, SVGLengthMode, Exce ptionState&) const; 73 float convertValueFromUserUnitsToPercentage(float value, SVGLengthMode, Exce ptionState&) const;
74 float convertValueFromPercentageToUserUnits(float value, SVGLengthMode, Exce ptionState&) const; 74 float convertValueFromPercentageToUserUnits(float value, SVGLengthMode, Exce ptionState&) const;
75 static float convertValueFromPercentageToUserUnits(float value, SVGLengthMod e, const FloatSize&); 75 static float convertValueFromPercentageToUserUnits(float value, SVGLengthMod e, const FloatSize& viewportSize);
76 static float convertValueFromPercentageToUserUnits(const SVGLength& value, c onst FloatSize& viewportSize);
76 77
77 float convertValueFromUserUnitsToEMS(float value, ExceptionState&) const; 78 float convertValueFromUserUnitsToEMS(float value, ExceptionState&) const;
78 float convertValueFromEMSToUserUnits(float value, ExceptionState&) const; 79 float convertValueFromEMSToUserUnits(float value, ExceptionState&) const;
79 80
80 float convertValueFromUserUnitsToEXS(float value, ExceptionState&) const; 81 float convertValueFromUserUnitsToEXS(float value, ExceptionState&) const;
81 float convertValueFromEXSToUserUnits(float value, ExceptionState&) const; 82 float convertValueFromEXSToUserUnits(float value, ExceptionState&) const;
82 83
83 RawPtrWillBeMember<const SVGElement> m_context; 84 RawPtrWillBeMember<const SVGElement> m_context;
84 }; 85 };
85 86
86 } // namespace blink 87 } // namespace blink
87 88
88 #endif // SVGLengthContext_h 89 #endif // SVGLengthContext_h
OLDNEW
« no previous file with comments | « Source/core/svg/SVGLength.cpp ('k') | Source/core/svg/SVGLengthContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698