Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: src/mips64/code-stubs-mips64.cc

Issue 861193008: MIPS64: fix wrong register use in LoadIndexedStringStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1329 matching lines...) Expand 10 before | Expand all | Expand 10 after
1340 __ Jump(ra); 1340 __ Jump(ra);
1341 } 1341 }
1342 1342
1343 1343
1344 void LoadIndexedStringStub::Generate(MacroAssembler* masm) { 1344 void LoadIndexedStringStub::Generate(MacroAssembler* masm) {
1345 // Return address is in ra. 1345 // Return address is in ra.
1346 Label miss; 1346 Label miss;
1347 1347
1348 Register receiver = LoadDescriptor::ReceiverRegister(); 1348 Register receiver = LoadDescriptor::ReceiverRegister();
1349 Register index = LoadDescriptor::NameRegister(); 1349 Register index = LoadDescriptor::NameRegister();
1350 Register scratch = a4; 1350 Register scratch = a5;
1351 Register result = v0; 1351 Register result = v0;
1352 DCHECK(!scratch.is(receiver) && !scratch.is(index)); 1352 DCHECK(!scratch.is(receiver) && !scratch.is(index));
1353 DCHECK(!FLAG_vector_ics || 1353 DCHECK(!FLAG_vector_ics ||
1354 (!scratch.is(VectorLoadICDescriptor::VectorRegister()) && 1354 (!scratch.is(VectorLoadICDescriptor::VectorRegister()) &&
1355 result.is(VectorLoadICDescriptor::SlotRegister()))); 1355 result.is(VectorLoadICDescriptor::SlotRegister())));
1356 1356
1357 // StringCharAtGenerator doesn't use the result register until it's passed 1357 // StringCharAtGenerator doesn't use the result register until it's passed
1358 // the different miss possibilities. If it did, we would have a conflict 1358 // the different miss possibilities. If it did, we would have a conflict
1359 // when FLAG_vector_ics is true. 1359 // when FLAG_vector_ics is true.
1360 StringCharAtGenerator char_at_generator(receiver, index, scratch, result, 1360 StringCharAtGenerator char_at_generator(receiver, index, scratch, result,
(...skipping 3821 matching lines...) Expand 10 before | Expand all | Expand 10 after
5182 kStackUnwindSpace, NULL, 5182 kStackUnwindSpace, NULL,
5183 MemOperand(fp, 6 * kPointerSize), NULL); 5183 MemOperand(fp, 6 * kPointerSize), NULL);
5184 } 5184 }
5185 5185
5186 5186
5187 #undef __ 5187 #undef __
5188 5188
5189 } } // namespace v8::internal 5189 } } // namespace v8::internal
5190 5190
5191 #endif // V8_TARGET_ARCH_MIPS64 5191 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698