Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 861173004: Do not generalize field representations when making elements kind or observed transition. (Closed)

Created:
5 years, 11 months ago by Igor Sheludko
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not generalize field representations when making elements kind or observed transition. BUG=chromium:448711 LOG=y Committed: https://crrev.com/7f9b2fa699ae48d1a766e87c14f3b89a2c0d3cd0 Cr-Commit-Position: refs/heads/master@{#26289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -41 lines) Patch
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 3 chunks +49 lines, -32 lines 0 comments Download
A + test/mjsunit/regress/regress-448711.js View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
5 years, 11 months ago (2015-01-21 17:28:21 UTC) #2
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-27 10:48:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861173004/1
5 years, 11 months ago (2015-01-27 10:49:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 11:19:05 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 11:19:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f9b2fa699ae48d1a766e87c14f3b89a2c0d3cd0
Cr-Commit-Position: refs/heads/master@{#26289}

Powered by Google App Engine
This is Rietveld 408576698