Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 861153003: improve measurement of completion performance (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: slightly adjust text Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index 9252382c0bcf178a0fb4a1bd647fe47df0c4aa12..4a194eeedd9e698406fe2b9287ebd1be9f97f883 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -57,9 +57,8 @@ class CompletionDomainHandler implements RequestHandler {
/**
* The maximum number of performance measurements to keep.
- * This defaults to zero for efficiency, but clients may change this.
*/
- int performanceListMaxLength = 0;
+ static const int performanceListMaxLength = 50;
/**
* Performance for the last priority change event.
@@ -185,10 +184,11 @@ class CompletionDomainHandler implements RequestHandler {
});
if (notificationCount == 1) {
performance.logFirstNotificationComplete('notification 1 complete');
+ performance.suggestionCountFirst = result.suggestions.length;
}
if (result.last) {
performance.notificationCount = notificationCount;
- performance.suggestionCount = result.suggestions.length;
+ performance.suggestionCountLast = result.suggestions.length;
performance.complete();
}
});

Powered by Google App Engine
This is Rietveld 408576698