Remove WAPI-related code, except the type definition of ResourceEntry.

Remove WAPI-related code, except the type definition of ResourceEntry.

To remove ResourceEntry completely, tests for syncFileSystem need to be modified.
I'll do it by a separate CL.

BUG=357038
TBR=rogerta@chromium.org
TBRing for removal of unused files from *.gyp and *.gn under google_api
TEST=build all targets

Committed: https://crrev.com/99daa8e4da877ec034860c63f8564a6dc5382aed
Cr-Commit-Position: refs/heads/master@{#313202}

[fukino, 2015-01-22 07:48:30]

fukino@chromium.org changed reviewers:
+ hashimoto@chromium.org, rogerta@chromium.org, tzik@chromium.org

[fukino, 2015-01-22 07:48:31]

tzik@:      PTAL at c/b/sync_file_system
rogerta@:   PTAL at goog_apis/{BUILD.gn, google_apis.gyp}
hashimoto@: PTAL at the rest.
Thanks!

[nhiroki, 2015-01-22 08:01:20]

LGTM for sync_file_system (on behalf of tzik@)

[hashimoto, 2015-01-22 08:02:02]

Really glad to see this change, thanks!
google_apis, chrome/browser/drive, chrome/browser/chromeos/drive lgtm.

I think you need someone to approve chrome/browser/apps/drive.

https://codereview.chromium.org/861133002/diff/40001/chrome/browser/drive/dri...
File chrome/browser/drive/drive_api_util_unittest.cc (right):

https://codereview.chromium.org/861133002/diff/40001/chrome/browser/drive/dri...
chrome/browser/drive/drive_api_util_unittest.cc:10: #include
"google_apis/drive/gdata_wapi_parser.h"
nit: Still need to include this?

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/drive_...
File google_apis/drive/drive_common_callbacks.h (right):

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/drive_...
google_apis/drive/drive_common_callbacks.h:22: GetResourceEntryCallback;
nit: This typedef if unused?

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/gdata_...
File google_apis/drive/gdata_wapi_parser.h (right):

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/gdata_...
google_apis/drive/gdata_wapi_parser.h:9: #include <vector>
nit: No need to include this?

[fukino, 2015-01-22 09:02:31]

fukino@chromium.org changed reviewers:
+ kinaba@chromium.org, nhiroki@chromium.org
- tzik@chromium.org

[fukino, 2015-01-22 09:02:32]

Thank you for the review, hiroki@ and hashimoto@!

kinaba@: PTAL at chrome/browser/apps/drive/drive_service_bridge.cc

https://codereview.chromium.org/861133002/diff/40001/chrome/browser/drive/dri...
File chrome/browser/drive/drive_api_util_unittest.cc (right):

https://codereview.chromium.org/861133002/diff/40001/chrome/browser/drive/dri...
chrome/browser/drive/drive_api_util_unittest.cc:10: #include
"google_apis/drive/gdata_wapi_parser.h"
On 2015/01/22 08:02:01, hashimoto wrote:
> nit: Still need to include this?

Thanks! removed.

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/drive_...
File google_apis/drive/drive_common_callbacks.h (right):

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/drive_...
google_apis/drive/drive_common_callbacks.h:22: GetResourceEntryCallback;
On 2015/01/22 08:02:01, hashimoto wrote:
> nit: This typedef if unused?

Done (Removed)

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/gdata_...
File google_apis/drive/gdata_wapi_parser.h (right):

https://codereview.chromium.org/861133002/diff/40001/google_apis/drive/gdata_...
google_apis/drive/gdata_wapi_parser.h:9: #include <vector>
On 2015/01/22 08:02:01, hashimoto wrote:
> nit: No need to include this?

Done.

[kinaba, 2015-01-22 09:42:35]

LGTM!!!!!!11111

[fukino, 2015-01-23 19:07:24]

Friendly ping: @rogerta

[fukino, 2015-01-26 13:05:45]

ping > @rogerta

[fukino, 2015-01-27 01:00:47]

Hi @rogerta, I TBRed you for simple removal of unused files from
google_apis/BUILD.gn and google_apis/google_apis.gyp.
Please check them if you have time. Thank you.

[fukino, 2015-01-27 01:00:47]

Hi @rogerta, I TBRed you for simple removal of unused files from
google_apis/BUILD.gn and google_apis/google_apis.gyp.
Please check them if you have time. Thank you.

[fukino, 2015-01-27 01:00:52]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2015-01-27 01:01:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/861133002/40002

[commit-bot: I haz the power, 2015-01-27 01:54:03]

Committed patchset #4 (id:40002)

[commit-bot: I haz the power, 2015-01-27 01:55:06]

Patchset 4 (id:??) landed as
https://crrev.com/99daa8e4da877ec034860c63f8564a6dc5382aed
Cr-Commit-Position: refs/heads/master@{#313202}