Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Issue 861113003: Fix issues with replay_process in ipc fuzzer. Make it compile on windows. (Closed)

Created:
5 years, 11 months ago by inferno
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issues with replay_process in ipc fuzzer. Make it compile on windows. R=tsepez@chromium.org,mbarbella@chromium.org BUG=450268 Committed: https://crrev.com/c0b8224c61a3705fb9e8ca3cae4118ac1573f292 Cr-Commit-Position: refs/heads/master@{#312643}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Patch Set 3 : Fix typo plaform #

Patch Set 4 : Force log destination to stderr for replay_process since windows defaults to file and causes null c… #

Patch Set 5 : Log to both stderr, file since stderr is hard to get on windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -8 lines) Patch
M build/all.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/mutate/cf_package_builder.py View 1 2 1 chunk +22 lines, -4 lines 0 comments Download
M tools/ipc_fuzzer/play_testcase.py View 1 2 2 chunks +22 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.cc View 1 2 3 4 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
inferno
tsepez: for ipc_fuzzer changes. thakis: for build/all.gyp changes
5 years, 11 months ago (2015-01-21 23:58:50 UTC) #2
Nico
build/all.gyp lgtm
5 years, 11 months ago (2015-01-22 00:12:59 UTC) #3
Tom Sepez
replay_process.cc LGTM https://codereview.chromium.org/861113003/diff/1/tools/ipc_fuzzer/mutate/cf_package_builder.py File tools/ipc_fuzzer/mutate/cf_package_builder.py (right): https://codereview.chromium.org/861113003/diff/1/tools/ipc_fuzzer/mutate/cf_package_builder.py#newcode18 tools/ipc_fuzzer/mutate/cf_package_builder.py:18: FUZZER_LIST_FOR_PLATFORM_DICT = { We should probably just ...
5 years, 11 months ago (2015-01-22 00:13:06 UTC) #4
inferno
On 2015/01/22 00:13:06, Tom Sepez wrote: > replay_process.cc LGTM > Added another tiny change to ...
5 years, 11 months ago (2015-01-22 02:05:35 UTC) #5
Tom Sepez
Still lgtm
5 years, 11 months ago (2015-01-22 18:32:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861113003/80001
5 years, 11 months ago (2015-01-22 18:35:39 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-22 18:41:23 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 18:42:57 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c0b8224c61a3705fb9e8ca3cae4118ac1573f292
Cr-Commit-Position: refs/heads/master@{#312643}

Powered by Google App Engine
This is Rietveld 408576698