chrome/browser/ui/tab_helpers.cc - Issue 861103002: Credentials chooser UI for Android.

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review, please Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 283933334bfea0d86ccab58da339abfdc8a515ca..2b8970d790872e98d0ad4ed7162336a01b271326 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -42,6 +42,7 @@

#include "chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.h"

#include "chrome/browser/ui/android/context_menu_helper.h"

#include "chrome/browser/ui/android/window_android_helper.h"

+#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"

#else

#include "chrome/browser/external_protocol/external_protocol_observer.h"

#include "chrome/browser/net/predictor_tab_helper.h"

@@ -49,7 +50,6 @@

#include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"

#include "chrome/browser/thumbnails/thumbnail_tab_helper.h"

#include "chrome/browser/ui/hung_plugin_tab_helper.h"

-#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"

#include "chrome/browser/ui/sad_tab_helper.h"

#include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"

#include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h"

@@ -165,6 +165,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

EnhancedBookmarkTabHelper::CreateForWebContents(web_contents);

SingleTabModeTabHelper::CreateForWebContents(web_contents);

WindowAndroidHelper::CreateForWebContents(web_contents);

+ ManagePasswordsUIController::CreateForWebContents(web_contents);

Peter Kasting 2015/02/18 00:23:05 This doesn't seem right -- didn't you mean to crea

melandory 2015/02/18 21:15:34 You're right. Fixed.

#else

chrome_browser_net::PredictorTabHelper::CreateForWebContents(web_contents);

extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(

@@ -172,7 +173,6 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

extensions::WebNavigationTabObserver::CreateForWebContents(web_contents);

ExternalProtocolObserver::CreateForWebContents(web_contents);

HungPluginTabHelper::CreateForWebContents(web_contents);

- ManagePasswordsUIController::CreateForWebContents(web_contents);

pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(

web_contents,

scoped_ptr<pdf::PDFWebContentsHelperClient>(