chrome/android/java/res/layout/account_chooser_infobar_item.xml - Issue 861103002: Credentials chooser UI for Android.

Side by Side Diff: chrome/android/java/res/layout/account_chooser_infobar_item.xml

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review, please Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/account_chooser_infobar_buttonbar.xml ('K') | « chrome/android/java/res/layout/account_chooser_infobar_buttonbar.xml ('k') | chrome/android/java/res/layout/account_chooser_infobar_items.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- TODO(melandory): remove selectable background once ListView used to represe nt credentials-->

	7 <LinearLayout

	8 xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:padding="8dp"

	12 android:background="?attr/selectableItemBackground"

	13 android:orientation="horizontal" >

	14 <ImageView

	15 android:id="@+id/profile_image"

	16 android:layout_gravity="center_vertical"

	17 android:layout_width="32dp"

	18 android:layout_height="32dp"

	19 android:contentDescription="@null"/>

	20 <LinearLayout

	21 android:layout_width="0dp"

	22 android:layout_height="wrap_content"

	23 android:layout_weight="1"

	24 android:layout_gravity="center_vertical"

	25 android:layout_margin="8dp"

	26 android:orientation="vertical">

	27 <TextView

	28 android:id="@+id/username"

	29 android:layout_width="wrap_content"

	30 android:layout_height="wrap_content"

	31 android:ellipsize="end"

	32 android:singleLine="true"

	33 android:textAppearance="?android:attr/textAppearanceMedium"/>
	newt (away) 2015/02/17 21:49:07 textAppearanceMedium and textAppearanceSmall are q textAppearanceMedium and textAppearanceSmall are quite different on Android L devices compared to earlier devices. It's safer to declare the size and color explicitly rather than using a textAppearance attribute melandory 2015/02/18 21:15:34 I've chosen same font settings as native Android i Show quoted text On 2015/02/17 21:49:07, newt wrote: > textAppearanceMedium and textAppearanceSmall are quite different on Android L > devices compared to earlier devices. It's safer to declare the size and color > explicitly rather than using a textAppearance attribute I've chosen same font settings as native Android implementation has, because I think having same appearance is more important than having consistent appearance across Android versions.
	34 <TextView

	35 android:id="@+id/display_name"

	36 android:textAppearance="?android:attr/textAppearanceSmall"

	37 android:singleLine="true"

	38 android:ellipsize="end"

	39 android:layout_width="wrap_content"
	newt (away) 2015/02/17 21:49:07 Attributes should be in this order: - id - layou Attributes should be in this order: - id - layout_width - layout_height - other layout_* attributes - other attributes, generally alphabetized melandory 2015/02/18 21:15:34 Done. Show quoted text On 2015/02/17 21:49:07, newt wrote: > Attributes should be in this order: > - id > - layout_width > - layout_height > - other layout_* attributes > - other attributes, generally alphabetized Done.
	40 android:layout_height="wrap_content"/>

	41 </LinearLayout>

	42 </LinearLayout>

OLD	NEW