chrome/android/java/res/layout/account_chooser_infobar_buttonbar.xml - Issue 861103002: Credentials chooser UI for Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/account_chooser_infobar_buttonbar.xml

Issue 861103002: Credentials chooser UI for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review, please Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2015/02/17 21:49:07 InfoBarLayout should now have everything you need InfoBarLayout should now have everything you need to use standard infobar buttons and get rid of this file. Something like this should work: public void createContent(InfoBarLayout layout) { layout.setButtons("No thanks", null); View moreButton = ButtonCompat.createBorderlessButton(context); moreButton.setOnClickListener(...); layout.setCustomViewInButtonRow(moreButton); } melandory 2015/02/18 21:15:33 Done. Show quoted text On 2015/02/17 21:49:07, newt wrote: > InfoBarLayout should now have everything you need to use standard infobar > buttons and get rid of this file. > > Something like this should work: > > public void createContent(InfoBarLayout layout) { > layout.setButtons("No thanks", null); > View moreButton = ButtonCompat.createBorderlessButton(context); > moreButton.setOnClickListener(...); > layout.setCustomViewInButtonRow(moreButton); > } Done.
	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 style="?attr/buttonBarStyle"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:orientation="horizontal" >

	12 <Button

	13 android:id="@+id/account_chooser_more"

	14 android:text="@string/account_chooser_infobar_more_button"

	15 android:background="?attr/selectableItemBackground"

	16 style="?attr/buttonBarButtonStyle"

	17 android:paddingStart="8dp"

	18 android:paddingEnd="8dp"

	19 android:layout_width="wrap_content"

	20 android:layout_height="match_parent"

	21 android:height="36dp"

	22 android:gravity="center_vertical\|start\|end"/>

	23 <Button

	24 style="?attr/buttonBarButtonStyle"

	25 android:text="@string/account_chooser_infobar_no_thanks_button"

	26 android:id="@+id/account_chooser_no_thanks"

	27 android:height="36dp"

	28 android:layout_width="wrap_content"

	29 android:layout_height="match_parent"

	30 android:paddingStart="8dp"

	31 android:paddingEnd="8dp"

	32 android:background="?attr/selectableItemBackground"/>

	33 </LinearLayout>

OLD	NEW