Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java

Issue 8611004: Changed the Problems view to sort the description column by the description text first, and file ... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java (revision 1624)
+++ editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java (working copy)
@@ -537,27 +537,27 @@
return val;
}
- val = compareResourceName(marker1, marker2);
+ val = compareProblemDescription(marker1, marker2);
if (val != 0) {
return val;
}
- val = compareLineNumber(marker1, marker2);
+ val = compareResourceName(marker1, marker2);
if (val != 0) {
return val;
}
- return compareProblemDescription(marker1, marker2);
+ return compareLineNumber(marker1, marker2);
} else if (sortColumn == 1) {
- val = compareResourceName(marker1, marker2);
+ val = compareSeverity(marker1, marker2);
if (val != 0) {
return val;
}
- val = compareSeverity(marker1, marker2);
+ val = compareResourceName(marker1, marker2);
if (val != 0) {
return val;
@@ -736,6 +736,7 @@
tableViewer.addSelectionChangedListener(goToMarkerAction);
tableSorter = new TableSorter();
+ tableSorter.setColumn(1);
tableViewer.setComparator(tableSorter);
tableViewer.getTable().setSortDirection(SWT.UP);
@@ -748,8 +749,6 @@
descriptionColumn.getColumn().setResizable(true);
enableSorting(descriptionColumn.getColumn(), 0);
- tableViewer.getTable().setSortColumn(descriptionColumn.getColumn());
-
TableViewerColumn fileNameColumn = new TableViewerColumn(tableViewer, SWT.LEFT);
fileNameColumn.setLabelProvider(new FileNameLabelProvider());
fileNameColumn.getColumn().setText("Location");
@@ -757,6 +756,8 @@
fileNameColumn.getColumn().setResizable(true);
enableSorting(fileNameColumn.getColumn(), 1);
+ tableViewer.getTable().setSortColumn(fileNameColumn.getColumn());
+
// TableViewerColumn typeColumn = new TableViewerColumn(tableViewer, SWT.LEFT);
// typeColumn.setLabelProvider(new TypeLabelProvider());
// typeColumn.getColumn().setText("Type");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698