Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 861093004: iOS gtest launcher: make simple unit tests like base_unittests work (Closed)

Created:
5 years, 11 months ago by Paweł Hajdan Jr.
Modified:
5 years, 11 months ago
Reviewers:
lliabraa, sky
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -52 lines) Patch
M base/test/gtest_util.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M base/test/gtest_util.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/test/gtest_xml_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/launcher/test_launcher.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M base/test/launcher/test_launcher_ios.cc View 5 chunks +29 lines, -6 lines 0 comments Download
M base/test/launcher/unit_test_launcher.h View 2 chunks +31 lines, -1 line 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 9 chunks +61 lines, -29 lines 0 comments Download
M base/test/test_suite.cc View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-22 14:06:32 UTC) #2
sky
LGTM https://codereview.chromium.org/861093004/diff/1/base/test/gtest_util.h File base/test/gtest_util.h (right): https://codereview.chromium.org/861093004/diff/1/base/test/gtest_util.h#newcode21 base/test/gtest_util.h:21: // Constructs a full test name given a ...
5 years, 11 months ago (2015-01-22 18:40:46 UTC) #3
lliabraa
lgtm
5 years, 11 months ago (2015-01-23 13:27:24 UTC) #5
lliabraa
5 years, 11 months ago (2015-01-23 13:27:38 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/861093004/diff/1/base/test/gtest_util.h File base/test/gtest_util.h (right): https://codereview.chromium.org/861093004/diff/1/base/test/gtest_util.h#newcode21 base/test/gtest_util.h:21: // Constructs a full test name given a test ...
5 years, 11 months ago (2015-01-23 13:29:58 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/19368c060c5a43ef85c00087661bffe88a09293c Cr-Commit-Position: refs/heads/master@{#312829}
5 years, 11 months ago (2015-01-23 13:35:01 UTC) #9
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-23 13:35:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
19368c060c5a43ef85c00087661bffe88a09293c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698