Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 861083003: Moved declare_args for enable_oilpan from Source/config.gni to public/features.gni (Closed)

Created:
5 years, 11 months ago by tasak
Modified:
5 years, 11 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Moved declare_args for enable_oilpan from Source/config.gni to public/features.gni. This makes enable_oilpan value public and chrome can know whether a given binary is oilpan-enabled or not during compile time. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188784

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M Source/config.gni View 2 chunks +1 line, -3 lines 0 comments Download
A public/features.gni View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tasak
Would you review this CL?
5 years, 11 months ago (2015-01-21 11:23:33 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-21 15:11:35 UTC) #4
brettw
lgtm
5 years, 11 months ago (2015-01-21 18:05:51 UTC) #5
tasak
Thank you for review.
5 years, 11 months ago (2015-01-22 01:36:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861083003/20001
5 years, 11 months ago (2015-01-22 01:37:24 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 01:41:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188784

Powered by Google App Engine
This is Rietveld 408576698