Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 861073004: Use the main world script context for mime handler postMessage. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the main world script context for mime handler postMessage. Previously, calling postMessage from an isolated world would use that world's context for calling the proxy frame's postMessage(). This resulted in "Illegal invocation" errors. This CL avoids this problem by using the main world script context when calling postMessage on the proxy frame. BUG=453184 Committed: https://crrev.com/438db6aecb5242715010c129ea508a80c16f9fa9 Cr-Commit-Position: refs/heads/master@{#313665}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sam McNally
5 years, 10 months ago (2015-01-29 03:01:11 UTC) #3
raymes
lgtm
5 years, 10 months ago (2015-01-29 03:25:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/861073004/20001
5 years, 10 months ago (2015-01-29 03:27:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-01-29 04:17:37 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 04:18:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/438db6aecb5242715010c129ea508a80c16f9fa9
Cr-Commit-Position: refs/heads/master@{#313665}

Powered by Google App Engine
This is Rietveld 408576698